-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/invoice and payment preferences #141
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,16 +35,14 @@ function onFrequencyAmountChange(value: number): void { | |
<span>{{ $t('hosting_preferences.invoices.frequency.part_one') }}</span> | ||
|
||
<TimeDropdownSelect | ||
is-disabled | ||
:value="props.data.frequency.period" | ||
:options="['N/A', 7, 30]" | ||
:options="[7, 15, 30]" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have two sets of selections: [7, 15, 30] here |
||
@update:selected-value="onFrequencyPeriodChange" | ||
/> | ||
|
||
<span>{{ $t('hosting_preferences.invoices.frequency.part_two') }}</span> | ||
|
||
<BaseEditableInput | ||
is-disabled | ||
:value="formatCurrency(Number(props.data.frequency.amount), 0)" | ||
unit="HF" | ||
class="invoices-frequency-section__amount" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -151,14 +151,10 @@ export default { | |
part_one: 'Payment is due', | ||
part_two: 'after invoice date' | ||
}, | ||
note_one: { | ||
part_one: '*hApps will be paused from hosting if payment is not received', | ||
note: { | ||
part_one: '*Apps will be paused from hosting if payment is not received', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are we changing to Apps now? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just following the designs on figma |
||
part_two: 'after invoice date' | ||
}, | ||
note_two: { | ||
part_one: '*hApps will be removed if payment is not received', | ||
part_two: 'after invoice date' | ||
} | ||
}, | ||
prices: { | ||
header: 'Price Configuration', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have two sets of selections: [7, 15, 28] here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, that is intentional. The want invoices Due to have a different selection than Invoices Frequency.