Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/histogram chart #161

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix/histogram chart #161

merged 1 commit into from
May 20, 2024

Conversation

mateuszRybczonek
Copy link
Contributor

@mateuszRybczonek mateuszRybczonek commented May 20, 2024

This PR fixes:

  • issues with histogram no rendering is certain scenarios
  • format of HF shown on the chart
  • total value to show total paid and unpaid earnings

It also adds:

  • loading state to the histogram
Screenshot 2024-05-20 at 12 53 33

@mateuszRybczonek mateuszRybczonek self-assigned this May 20, 2024
Copy link

Deploying host-console-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e7c253
Status: ✅  Deploy successful!
Preview URL: https://34eda140.host-console-ui.pages.dev
Branch Preview URL: https://fix-histogram-chart.host-console-ui.pages.dev

View logs

!isErrorPredicate(dashboardStore.hostEarnings)
? dashboardStore.hostEarnings.earnings?.last7days
: 0
)
/* eslint-enable @typescript-eslint/no-magic-numbers */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to be there?

}>()

const { goToHoloFuel } = useGoToHoloFuel()
const { t } = useI18n()

// const trendValue = computed(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good the see commented code being removed

@mateuszRybczonek mateuszRybczonek merged commit 39b9b3b into develop May 20, 2024
4 checks passed
@mateuszRybczonek mateuszRybczonek deleted the fix/histogram-chart branch May 20, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants