Fix hpos version endpoint #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Paterick
commented
Jul 23, 2024
Paterick
commented
- Previous HPOS api returned a json object for the apps/core/version endoint. The Rust version of the HPOS api changed this to be a string. I changed the Rust HPOS api back to return a json object to match the interface of the previous version to fix braking issues in Holofuel UI and Cloud Console. This change broke host-console-ui so this PR reverts it back to expect a json object from the version apps/core/version endpoint.
peeech
approved these changes
Jul 23, 2024
zo-el
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.