-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow to support v3 config files #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some suggestions and one issue that will need a small update
// clear passphrase from memory | ||
seedPassphrase = null | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you're not clearing it from memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to create a 2nd timer for the revocation key file. If I tried to save both files at the same time the revocation key file was overwriting the seed file. I clear it from memory on line 222 now.
gen-web/src/index.js
Outdated
@@ -226,7 +256,7 @@ | |||
|
|||
setTimeout(() => { | |||
try { | |||
filesaver.saveAs(configFileBlob, genConfigFileName(deviceNumber, deviceID)) | |||
filesaver.saveAs(configFileBlob, genConfigFileName(HOLO_PORT_STARTING_DEVICE_NUMBER, deviceID)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may need to be reverted. else it will always use the deviceNumber as 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now genConfigFileName doesn't use the device number to generate the file name.
gen-web/src/utils.js
Outdated
return `${FILE_PREFIX}-primary-${pubKey.substring(0, 5)}${FILE_TYPE}` | ||
} else { | ||
return `${FILE_PREFIX}-secondary-${pubKey.substring(0, 5)}${FILE_TYPE}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should update the logic as well. we don't need it to be primary or secondary files.
Because of the new derivation paths, all the configs will be the same so we could use hp-config-...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made your suggested change. I'll confirm with C that this is ok.
and confirmed 1st device has derivation path 1:
{ "v3": { "device_bundle": "k6VoY3NiMJGWonB3xBDP7dFKjz5hCudXjakaDlG3zSAAAcQYerE8Pj_bzkln3rIqKONnALXaBRp2LdjHxDEPyzCd60zjQ-c_Z5P8tneEN3tfwFqMEKpLJErmeiHyYVjkCjTpUksBtRXnYjalnCz6xBeBqmJ1bmRsZVR5cGWqZGV2aWNlUm9vdA", "device_derivation_path": "1", "revocation_pub_key": "dSwFjSrPDHOMNnyez0+nYIvojP8PwNWu/oHBMqJVf5o", "holoport_id": "30vgd8043wot7jz2msvl6h0plck4a9fx03n30tg3xrgxh4g35m", "registration_code": "abcd", "settings": { "admin": { "email": "[email protected]", "public_key": "Ap9B2dEuM6EfXE6EYoWF57yjgTg9HMp9Y3CyLhDje5A" } } } }
And 2nd device has derivation path 2:
{ "v3": { "device_bundle": "k6VoY3NiMJGWonB3xBCzopvyQKVwKvHZa2nW6LOezSAAAcQYjk5Z6BNiY5xayA3fH5K_AkLFVG6r9PYnxDF3xTA77O5CvM9pgi9TD9J-jzpsF00zIeKsNzKDtjDm7JngFXtPIRJK0tsM_aDa7v4GxBeBqmJ1bmRsZVR5cGWqZGV2aWNlUm9vdA", "device_derivation_path": "2", "revocation_pub_key": "dSwFjSrPDHOMNnyez0+nYIvojP8PwNWu/oHBMqJVf5o", "holoport_id": "24uo4lv83e8nv86gnmsp23rag5ndln85bkx43gawjo1tc9pyw4", "registration_code": "abcd", "settings": { "admin": { "email": "[email protected]", "public_key": "llWNxlEtXZxWqrxcATui3W10xEg4Z9v1ROBL2bXO10Y" } } } }
Link to ticket in gitlab
[x] Update wizard to generate master seed AND revocation code
[x] Design review w/ C for the UI implementation comparing against Figma designs prior to testing
[x] Removed "Important Note" dialog
[x] Include revocation code in V3 config files
[x] Update UI to match changes in figma
Intro:
Intro 2
Step 1:
Step 2A:
Step 2:
Step 3:
Step 3 (during save):
Step 3 (after save):
Step 4:
Step 4A:
Step 5:
Step 6:
Exit step 1:
Exit step 2: