Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to support v3 config files #130

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Conversation

Paterick
Copy link
Contributor

@Paterick Paterick commented Jul 24, 2024

Link to ticket in gitlab

[x] Update wizard to generate master seed AND revocation code
[x] Design review w/ C for the UI implementation comparing against Figma designs prior to testing
[x] Removed "Important Note" dialog
[x] Include revocation code in V3 config files
[x] Update UI to match changes in figma

Intro:

image

Intro 2

image

Step 1:

image

Step 2A:

image

Step 2:

image

Step 3:

image

Step 3 (during save):

image

Step 3 (after save):

image

Step 4:

image

Step 4A:

image

Step 5:

image

Step 6:

image

Exit step 1:

image

Exit step 2:

image

Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some suggestions and one issue that will need a small update

Comment on lines -197 to -199
// clear passphrase from memory
seedPassphrase = null

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you're not clearing it from memory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to create a 2nd timer for the revocation key file. If I tried to save both files at the same time the revocation key file was overwriting the seed file. I clear it from memory on line 222 now.

@@ -226,7 +256,7 @@

setTimeout(() => {
try {
filesaver.saveAs(configFileBlob, genConfigFileName(deviceNumber, deviceID))
filesaver.saveAs(configFileBlob, genConfigFileName(HOLO_PORT_STARTING_DEVICE_NUMBER, deviceID))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may need to be reverted. else it will always use the deviceNumber as 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now genConfigFileName doesn't use the device number to generate the file name.

Comment on lines 29 to 31
return `${FILE_PREFIX}-primary-${pubKey.substring(0, 5)}${FILE_TYPE}`
} else {
return `${FILE_PREFIX}-secondary-${pubKey.substring(0, 5)}${FILE_TYPE}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the logic as well. we don't need it to be primary or secondary files.

Because of the new derivation paths, all the configs will be the same so we could use hp-config-...

Copy link
Contributor Author

@Paterick Paterick Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made your suggested change. I'll confirm with C that this is ok.

image

and confirmed 1st device has derivation path 1:

{ "v3": { "device_bundle": "k6VoY3NiMJGWonB3xBDP7dFKjz5hCudXjakaDlG3zSAAAcQYerE8Pj_bzkln3rIqKONnALXaBRp2LdjHxDEPyzCd60zjQ-c_Z5P8tneEN3tfwFqMEKpLJErmeiHyYVjkCjTpUksBtRXnYjalnCz6xBeBqmJ1bmRsZVR5cGWqZGV2aWNlUm9vdA", "device_derivation_path": "1", "revocation_pub_key": "dSwFjSrPDHOMNnyez0+nYIvojP8PwNWu/oHBMqJVf5o", "holoport_id": "30vgd8043wot7jz2msvl6h0plck4a9fx03n30tg3xrgxh4g35m", "registration_code": "abcd", "settings": { "admin": { "email": "[email protected]", "public_key": "Ap9B2dEuM6EfXE6EYoWF57yjgTg9HMp9Y3CyLhDje5A" } } } }

image

And 2nd device has derivation path 2:

{ "v3": { "device_bundle": "k6VoY3NiMJGWonB3xBCzopvyQKVwKvHZa2nW6LOezSAAAcQYjk5Z6BNiY5xayA3fH5K_AkLFVG6r9PYnxDF3xTA77O5CvM9pgi9TD9J-jzpsF00zIeKsNzKDtjDm7JngFXtPIRJK0tsM_aDa7v4GxBeBqmJ1bmRsZVR5cGWqZGV2aWNlUm9vdA", "device_derivation_path": "2", "revocation_pub_key": "dSwFjSrPDHOMNnyez0+nYIvojP8PwNWu/oHBMqJVf5o", "holoport_id": "24uo4lv83e8nv86gnmsp23rag5ndln85bkx43gawjo1tc9pyw4", "registration_code": "abcd", "settings": { "admin": { "email": "[email protected]", "public_key": "llWNxlEtXZxWqrxcATui3W10xEg4Z9v1ROBL2bXO10Y" } } } }

@Paterick Paterick requested a review from zo-el July 30, 2024 17:39
@Paterick Paterick merged commit 6125ac1 into develop Jul 30, 2024
1 check passed
@Paterick Paterick deleted the v3_ui_tweaks-suggestion branch July 30, 2024 22:37
@zo-el zo-el mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants