Added missing v3 implementation #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zo-el
approved these changes
Aug 19, 2024
zo-el
approved these changes
Aug 20, 2024
vladossol
pushed a commit
that referenced
this pull request
Sep 2, 2024
* sudoken: v0.0.5 * sudoken: v0.0.6 * hc_seed_bundle: v0.1.4 * holochain: v0.1.0-rc * version bump * seed-bundle: holoport_key * set code owners * sudoken: 0.0.9 * fix: quick-start-status-code * bump sodoken * bump wasm-bindgen-cli * use workspace.dependencies * bump ed25519-dalek to 2.1.1 * update versions in Cargo.toml * move to flake.nix * update cargo deps * wip: v3 * wip: v3 * fix tests * added todos * hpos-config: tests * Interim commit with tests passing * ui tweaks and v3 updates * git ignore * pass pubkeys as bytes * fix error on multiple hps, ui tweaks, and re-enable memproof check * design review changes * pr feedback suggestions * fix package-lock issue * Added missing v3 implementation (#131) * Added missing v3 implementation * Added email getter on Config * Minimally updated gen-cli to use Clap --------- Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Joel Ulahanna <[email protected]> * Added missing commit for host pub key (#134) Co-authored-by: Matthew Geddes <[email protected]> * feat: set up direnv, formatter and format flake (#133) * configure direnv * chore(nix): configure formatter and run `nix fmt` --------- Co-authored-by: zo-el <[email protected]> Co-authored-by: Robbie Carlton <[email protected]> Co-authored-by: Alastair Ong <[email protected]> Co-authored-by: Zeeshan <[email protected]> Co-authored-by: peeech <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Patrick Winfield <[email protected]> Co-authored-by: Patrick Winfield <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Stefan Junker <[email protected]>
zeeshan595
pushed a commit
that referenced
this pull request
Sep 4, 2024
* sudoken: v0.0.5 * sudoken: v0.0.6 * hc_seed_bundle: v0.1.4 * holochain: v0.1.0-rc * version bump * seed-bundle: holoport_key * set code owners * sudoken: 0.0.9 * fix: quick-start-status-code * bump sodoken * bump wasm-bindgen-cli * use workspace.dependencies * bump ed25519-dalek to 2.1.1 * update versions in Cargo.toml * move to flake.nix * update cargo deps * wip: v3 * wip: v3 * fix tests * added todos * hpos-config: tests * Interim commit with tests passing * ui tweaks and v3 updates * git ignore * pass pubkeys as bytes * fix error on multiple hps, ui tweaks, and re-enable memproof check * design review changes * pr feedback suggestions * fix package-lock issue * Added missing v3 implementation (#131) * Added missing v3 implementation * Added email getter on Config * Minimally updated gen-cli to use Clap --------- * Added missing commit for host pub key (#134) * feat: set up direnv, formatter and format flake (#133) * configure direnv * chore(nix): configure formatter and run `nix fmt` --------- Co-authored-by: alastairong1 <[email protected]> Co-authored-by: zo-el <[email protected]> Co-authored-by: Robbie Carlton <[email protected]> Co-authored-by: Alastair Ong <[email protected]> Co-authored-by: Zeeshan <[email protected]> Co-authored-by: peeech <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Patrick Winfield <[email protected]> Co-authored-by: Patrick Winfield <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Stefan Junker <[email protected]>
zeeshan595
pushed a commit
that referenced
this pull request
Sep 4, 2024
* sudoken: v0.0.5 * sudoken: v0.0.6 * hc_seed_bundle: v0.1.4 * holochain: v0.1.0-rc * version bump * seed-bundle: holoport_key * set code owners * sudoken: 0.0.9 * fix: quick-start-status-code * bump sodoken * bump wasm-bindgen-cli * use workspace.dependencies * bump ed25519-dalek to 2.1.1 * update versions in Cargo.toml * move to flake.nix * update cargo deps * wip: v3 * wip: v3 * fix tests * added todos * hpos-config: tests * Interim commit with tests passing * ui tweaks and v3 updates * git ignore * pass pubkeys as bytes * fix error on multiple hps, ui tweaks, and re-enable memproof check * design review changes * pr feedback suggestions * fix package-lock issue * Added missing v3 implementation (#131) * Added missing v3 implementation * Added email getter on Config * Minimally updated gen-cli to use Clap --------- * Added missing commit for host pub key (#134) * feat: set up direnv, formatter and format flake (#133) * configure direnv * chore(nix): configure formatter and run `nix fmt` --------- Co-authored-by: alastairong1 <[email protected]> Co-authored-by: zo-el <[email protected]> Co-authored-by: Robbie Carlton <[email protected]> Co-authored-by: Alastair Ong <[email protected]> Co-authored-by: Zeeshan <[email protected]> Co-authored-by: peeech <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Patrick Winfield <[email protected]> Co-authored-by: Patrick Winfield <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Stefan Junker <[email protected]>
vladossol
pushed a commit
that referenced
this pull request
Oct 1, 2024
* sudoken: v0.0.5 * sudoken: v0.0.6 * hc_seed_bundle: v0.1.4 * holochain: v0.1.0-rc * version bump * seed-bundle: holoport_key * set code owners * sudoken: 0.0.9 * fix: quick-start-status-code * bump sodoken * bump wasm-bindgen-cli * use workspace.dependencies * bump ed25519-dalek to 2.1.1 * update versions in Cargo.toml * move to flake.nix * update cargo deps * wip: v3 * wip: v3 * fix tests * added todos * hpos-config: tests * Interim commit with tests passing * ui tweaks and v3 updates * git ignore * pass pubkeys as bytes * fix error on multiple hps, ui tweaks, and re-enable memproof check * design review changes * pr feedback suggestions * fix package-lock issue * Added missing v3 implementation (#131) * Added missing v3 implementation * Added email getter on Config * Minimally updated gen-cli to use Clap --------- Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Joel Ulahanna <[email protected]> * Added missing commit for host pub key (#134) Co-authored-by: Matthew Geddes <[email protected]> * feat: set up direnv, formatter and format flake (#133) * configure direnv * chore(nix): configure formatter and run `nix fmt` * feat: add passphrase confirmation (#138) * Added some basic logging (#139) Co-authored-by: Matthew Geddes <[email protected]> --------- Co-authored-by: zo-el <[email protected]> Co-authored-by: Robbie Carlton <[email protected]> Co-authored-by: Alastair Ong <[email protected]> Co-authored-by: Zeeshan <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Patrick Winfield <[email protected]> Co-authored-by: Patrick Winfield <[email protected]> Co-authored-by: Alastair Ong <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Matthew Geddes <[email protected]> Co-authored-by: Stefan Junker <[email protected]> Co-authored-by: Mateusz Rybczonek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like someone already merged the rest of my v3config branch changes into develop. I don't know why and didn't see a PR or review for that. This PR catches on missing V3 config case though.