Add sample mode 5 (#13) #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Y2, Cb2, Cr2. Add parameter scale. Add parameters Y_1, Cb_1, Cr_1, Y_2, Cb_2, Cr_2. (only for sample_mode=5)
msg7086
approved these changes
Dec 15, 2022
|
@Asd-g i remember you can edit file here so why you need pull request?? |
So that people can review the code before it's merged. Pretty common practice in a team where people want some extra eyes on their changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sample mode 5 - similar to sample mode 4 but with additional threshold checks - https://forum.doom9.org/showthread.php?p=1652256#post1652256 (#13) (avgDif, maxDif, midDif1, midDif2).
Also add new parameters for these additional checks (
Y_1,Cb_1,Cr_1,Y_2,Cb_2,Cr_2).Remove parameters
y2,cb2,cr2and add parameterscale. This way it's easily to change the behavior of the threshold parameters without adding second parameter for every threshold.