Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

components_order: allow ignore_missing_libraries in on_os #11650

Merged
merged 1 commit into from
Jul 5, 2021
Merged

components_order: allow ignore_missing_libraries in on_os #11650

merged 1 commit into from
Jul 5, 2021

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Jul 4, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Needed for: Homebrew/homebrew-core#80555

@dawidd6 dawidd6 requested a review from iMichka July 4, 2021 16:34
@BrewTestBot
Copy link
Member

Review period will end on 2021-07-06 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 4, 2021
@carlocab carlocab added the critical Critical change which should be shipped as soon as possible. label Jul 4, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 4, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@carlocab
Copy link
Member

carlocab commented Jul 4, 2021

Feel free to merge whenever you're ready.

@dawidd6 dawidd6 merged commit 35b15af into master Jul 5, 2021
@dawidd6 dawidd6 deleted the dawidd6-patch-1 branch July 5, 2021 04:52
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

@iMichka iMichka iMichka approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dawidd6 @BrewTestBot @carlocab @iMichka