-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsh@13: disable, tsh: deprecate #192342
tsh@13: disable, tsh: deprecate #192342
Conversation
Isn't there a teleport desktop cask? |
@SMillerDev , here is a release note.
The package install Anyway, |
It should be disabled too if upstream dropped support. |
3935b55
to
10c1ce5
Compare
10c1ce5
to
283ad52
Compare
283ad52
to
3fe1758
Compare
Maybe I didn't understand correctly, but tried to
|
Is the formula a full replacement for the tsh cask? It was my understanding that it is not. |
@SMillerDev , I think they are same but the only difference is notarization. Formula:
Teleport package v17 (which is now include tsh, tctl app, but they only have notarized binaries) So, I don't think there should be I am always happy to receive feedback, so keep asking if you doubt, or any suggestion is also welcome! |
Notarisation is a pretty big difference for security focused software such as teleport. For example, Touch ID based login probably doesn't work on the formula while it does on the cask. I think we should keep both. |
8d0652e
to
da183e4
Compare
da183e4
to
064efcb
Compare
bbdd908
to
f9bb6d2
Compare
f9bb6d2
to
2eb331d
Compare
download page only shows the version from 14 now, and so let's skip the livecheck for v13.
BTW,
tsh
is merged intoteleport
package from v17 and so there is no separate app now.So maybe we have to deprecate
tsh
. But we didn't registerteleport
cask and only formula is added.Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.