Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsh@13: disable, tsh: deprecate #192342

Merged
merged 2 commits into from
Nov 19, 2024
Merged

tsh@13: disable, tsh: deprecate #192342

merged 2 commits into from
Nov 19, 2024

Conversation

daeho-ro
Copy link
Member

download page only shows the version from 14 now, and so let's skip the livecheck for v13.

BTW, tsh is merged into teleport package from v17 and so there is no separate app now.
So maybe we have to deprecate tsh. But we didn't register teleport cask and only formula is added.


Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@daeho-ro daeho-ro added livecheck Issues or PRs related to livecheck ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. labels Nov 17, 2024
@SMillerDev
Copy link
Member

Isn't there a teleport desktop cask?

@daeho-ro
Copy link
Member Author

@SMillerDev , here is a release note.

Signed and notarized macOS assets
Starting from Teleport 17 macOS teleport.pkg installer includes signed and notarized tsh.app and tctl.app so downloading a separate tsh.pkg to use Touch ID is no longer

The package install teleport binary and now also tsh.app and tctl.app. We have a formula for teleport and so we didn't add a cask I think but now it is complicated situation.

Anyway, tsh@13 is out of scope and so the livecheck can be gone.

@SMillerDev
Copy link
Member

It should be disabled too if upstream dropped support.

@daeho-ro daeho-ro changed the title tsh@13: skip livecheck tsh@13: deprecate tsh: migrate to homebrew/core Nov 17, 2024
tap_migrations.json Outdated Show resolved Hide resolved
Casks/t/tsh.rb Outdated Show resolved Hide resolved
Casks/t/[email protected] Outdated Show resolved Hide resolved
@daeho-ro daeho-ro changed the title tsh@13: deprecate tsh: migrate to homebrew/core tsh@13: disable, tsh: deprecate, rename to teleport and migrate to homebrew/core Nov 18, 2024
@daeho-ro
Copy link
Member Author

Maybe I didn't understand correctly, but tried to

  • disable v13 that is not served on teleport homepage,
  • deprecate v16 that is still served (then should I keep without deprecate?)
  • for the next version, rename and migrate tap.

@SMillerDev
Copy link
Member

Is the formula a full replacement for the tsh cask? It was my understanding that it is not.

@daeho-ro
Copy link
Member Author

daeho-ro commented Nov 18, 2024

@SMillerDev , I think they are same but the only difference is notarization.

Formula:

ls -l /opt/homebrew/Cellar/teleport/17.0.1/bin/
.r-xr-xr-x daeho.ro admin 328 KB Sat Nov 16 16:35:23 2024 fdpass-teleport
.r-xr-xr-x daeho.ro admin  84 MB Sat Nov 16 16:35:23 2024 tbot
.r-xr-xr-x daeho.ro admin  88 MB Mon Nov 18 22:22:15 2024 tctl
.r-xr-xr-x daeho.ro admin 297 MB Sat Nov 16 16:35:23 2024 teleport
.r-xr-xr-x daeho.ro admin 101 MB Mon Nov 18 22:22:15 2024 tsh

Teleport package v17 (which is now include tsh, tctl app, but they only have notarized binaries)
image

So, I don't think there should be teleport cask and only formula is enough. That is why I tried to deprecate tsh cask.

I am always happy to receive feedback, so keep asking if you doubt, or any suggestion is also welcome!

@SMillerDev
Copy link
Member

Notarisation is a pretty big difference for security focused software such as teleport. For example, Touch ID based login probably doesn't work on the formula while it does on the cask.

I think we should keep both.

@daeho-ro daeho-ro force-pushed the tsh@13-livecheck branch 2 times, most recently from 8d0652e to da183e4 Compare November 18, 2024 14:03
@daeho-ro daeho-ro changed the title tsh@13: disable, tsh: deprecate, rename to teleport and migrate to homebrew/core tsh@13: disable, tsh: deprecate, rename to teleport 17.0.1 (new cask) Nov 18, 2024
cask_renames.json Outdated Show resolved Hide resolved
Casks/t/teleport.rb Outdated Show resolved Hide resolved
@daeho-ro daeho-ro changed the title tsh@13: disable, tsh: deprecate, rename to teleport 17.0.1 (new cask) tsh@13: disable, tsh: deprecate Nov 18, 2024
@daeho-ro daeho-ro force-pushed the tsh@13-livecheck branch 2 times, most recently from bbdd908 to f9bb6d2 Compare November 18, 2024 14:43
@p-linnane p-linnane merged commit 8bb147f into master Nov 19, 2024
9 checks passed
@p-linnane p-linnane deleted the tsh@13-livecheck branch November 19, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants