Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script.sh: gnupg #46497

Merged
merged 1 commit into from
May 11, 2018
Merged

script.sh: gnupg #46497

merged 1 commit into from
May 11, 2018

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Apr 29, 2018

Homebrew/brew#4120

The travis pre-installed gnupg is relatively recent but is missing several required dependancies (no idea if they would impact the functionality we need), seems easier just to upgrade it to the current version and install the missing deps which would also mirror the setup that most users have.

>>> brew info gnupg
gnupg: stable 2.2.6 (bottled)
GNU Pretty Good Privacy (PGP) package
https://gnupg.org/
/usr/local/Cellar/gnupg/2.2.1 (132 files, 10.3MB)
  Poured from bottle on 2017-09-19 at 20:01:30
/usr/local/Cellar/gnupg/2.2.3 (133 files, 10.3MB) *
  Poured from bottle on 2017-12-06 at 04:46:19
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/gnupg.rb
==> Dependencies
Build: pkg-config ✔
Required: npth ✔, gnutls ✘, libgpg-error ✘, libgcrypt ✘, libksba ✔, libassuan ✘, pinentry ✘, gettext ✔, adns ✔

@commitay commitay added awaiting maintainer feedback Issue needs response from a maintainer. travis labels Apr 29, 2018
run brew tap homebrew/bundle
run brew bundle dump --file="${HOME}/Brewfile"
fi
for cask in "${modified_casks[@]}"; do
if brew cask _stanza gpg "${cask}" > /dev/null; then
run brew outdated gnupg || run brew upgrade gnupg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we’re setting HOMEBREW_NO_AUTO_UPDATE earlier, then won’t brew outdated not properly check for the actual latest version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we run brew update as part of before_script.sh

https://travis-ci.org/caskroom/homebrew-cask/builds/372605401#L2192

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this won't work because the audit step will also check the gpg signature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be checked before _audit_modified_casks.

@commitay
Copy link
Contributor Author

commitay commented May 10, 2018

Yes, this should be checked before _audit_modified_casks.

Done.

Not sure what's causing this:
https://travis-ci.org/caskroom/homebrew-cask/builds/377088476#L2397

==> Failed command:
/usr/local/opt/gnupg/bin/gpg --no-default-keyring --keyring /Users/travis/Library/Caches/Homebrew/gpg/homebrew-keyring.gpg --receive-keys 2007B954
==> Standard Output of failed command:
==> Standard Error of failed command:
gpg: keybox '/Users/travis/Library/Caches/Homebrew/gpg/homebrew-keyring.gpg' created
gpg: keyserver receive failed: No route to host

@reitermarkus
Copy link
Member

Not sure what's causing this:

Probably just a temporary network issue.

@commitay commitay removed awaiting maintainer feedback Issue needs response from a maintainer. on hold labels May 10, 2018
@commitay
Copy link
Contributor Author

This seems to be working well with travis now, I've tried several Casks.

@commitay commitay merged commit a38a6ed into Homebrew:master May 11, 2018
@commitay commitay deleted the check-gpg branch May 11, 2018 01:21
@Homebrew Homebrew locked and limited conversation to collaborators Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants