-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script.sh: gnupg #46497
script.sh: gnupg #46497
Conversation
ci/travis/script.sh
Outdated
run brew tap homebrew/bundle | ||
run brew bundle dump --file="${HOME}/Brewfile" | ||
fi | ||
for cask in "${modified_casks[@]}"; do | ||
if brew cask _stanza gpg "${cask}" > /dev/null; then | ||
run brew outdated gnupg || run brew upgrade gnupg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we’re setting HOMEBREW_NO_AUTO_UPDATE
earlier, then won’t brew outdated
not properly check for the actual latest version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we run brew update
as part of before_script.sh
https://travis-ci.org/caskroom/homebrew-cask/builds/372605401#L2192
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this won't work because the audit step will also check the gpg signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should be checked before _audit_modified_casks
.
Done. Not sure what's causing this:
|
Probably just a temporary network issue. |
This seems to be working well with travis now, I've tried several Casks. |
Homebrew/brew#4120
The travis pre-installed
gnupg
is relatively recent but is missing several required dependancies (no idea if they would impact the functionality we need), seems easier just to upgrade it to the current version and install the missing deps which would also mirror the setup that most users have.