Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 23.9.0 #209037

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

node 23.9.0 #209037

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Feb 26, 2025 •
edited by cho-m
Loading

Created by brew bump

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue long dependent tests Set a long timeout for dependent testing labels Feb 26, 2025
@cho-m cho-m added linux Linux is specifically affected 13 Ventura is specifically affected 13-arm64 Ventura arm64 is specifically affected maintainer feedback Additional maintainers' opinions may be needed build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed maintainer feedback Additional maintainers' opinions may be needed labels Feb 26, 2025
@cho-m cho-m marked this pull request as draft February 26, 2025 20:42
@cho-m cho-m added in progress Stale bot should stay away and removed 13 Ventura is specifically affected 13-arm64 Ventura arm64 is specifically affected labels Feb 26, 2025
@daeho-ro daeho-ro mentioned this pull request Feb 28, 2025
Open
1 task
cho-m
cho-m reviewed Feb 28, 2025
View reviewed changes
@cho-m cho-m force-pushed the bump-node-23.9.0 branch 3 times, most recently from f9d4bcd to 3834c1c Compare March 1, 2025 05:36
cho-m
cho-m reviewed Mar 1, 2025
View reviewed changes
Formula/n/node.rb Outdated
end

on_linux do
depends_on "gcc" if DevelopmentTools.gcc_version("/usr/bin/gcc") < 12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove conditional as possible that bottle won't work with GCC 12-13.

Suggested change
depends_on "gcc" if DevelopmentTools.gcc_version("/usr/bin/gcc") < 12
depends_on "gcc"

More accurate (but not expressible) would be to have separate bottle pour dependency

Suggested change
depends_on "gcc" if DevelopmentTools.gcc_version("/usr/bin/gcc") < 12
depends_on "gcc" => :build if DevelopmentTools.gcc_version("/usr/bin/gcc") < 12
depends_on "gcc" => <pour-if-insufficient-system-gcc-abi>

@cho-m cho-m force-pushed the bump-node-23.9.0 branch from 3834c1c to 9a38a70 Compare March 1, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cho-m cho-m cho-m left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. icu4c ICU use is a significant feature of the PR or issue in progress Stale bot should stay away linux Linux is specifically affected long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrewTestBot @cho-m