Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift: migrate to boneyard #6268

Closed
wants to merge 1 commit into from
Closed

Conversation

zmwangx
Copy link
Contributor

@zmwangx zmwangx commented Oct 25, 2016

Created with brew boneyard-formula-pr.

@MikeMcQuaid
Copy link
Member

Why?

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 25, 2016

Swift is provided by Apple through Xcode or CLT. Not many people install this formula, nothing depends on it, no one cared to bring it to 3.0, and the last time I tried to bring it up-to-date with this patch it errored out in a non-obvious way. Lacking demand and enthusiasm, let just make it history.

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 25, 2016

@MikeMcQuaid I was just about to CC you since you originally added it.

@MikeMcQuaid
Copy link
Member

We're running a pretty old release that's probably worth trying to upgrade.

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 25, 2016

See comment above. If you can get it to work then sure.

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 25, 2016

My patch is a starting point: https://gist.github.com/zmwangx/0075ced732314f1902bdc12ef6e720e4.

@MikeMcQuaid
Copy link
Member

Given we've got some people installing/using this: 👎 on removing.

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 25, 2016

Then bring it to 3.0.

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 25, 2016

@MikeMcQuaid I take that to mean you'll fix it? Because I've done my fair share of work to update it, and don't plan to waste more human and CPU time on something with little return (the official channel is better). I also don't want to see swift in #5488 forever.

@zmwangx zmwangx deleted the swift-boneyard branch October 25, 2016 19:55
@MikeMcQuaid
Copy link
Member

I take that to mean you'll fix it?

Not necessarily but I'll take a look.

Because I've done my fair share of work to update it, and don't plan to waste more human and CPU time on something with little return (the official channel is better).

That's up to you (as my work is up to me). We shouldn't boneyard things people are using. I won't object when no-one is using them.

I also don't want to see swift in #5488 forever.

A maximum macOS requirement is the best short-term fix for these cases, I think.

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 25, 2016

We shouldn't boneyard things people are using.

Running brew install swift is not equivalent to using /usr/bin/local/swift (well, it's not even linked by default) regularly, especially when /usr/bin/swift is up-to-date and infinitely better supported (in this respect the swift formula is not comparable to any other dupe we have). A long time ago, when swift was initially open sourced, I tried brew install swift just out of curiosity. I surely didn't use it afterwards; in fact, I haven't even got past page fifty of The Swift Programming Language, despite having kept it in iBooks since Swift 1.0 beta. Given the enthusiasm in Swift in general and our relatively pathetic install stats, I wouldn't be surprised if the great majority of those install numbers come from novelty trials like mine.

Even if there are people using it, there's always /usr/bin/swift (or swift under whatever sdk path), so it's not like we're leaving people in the dark by boneyarding this formula. In fact, I would urge them to use Apple's swift.

@MikeMcQuaid
Copy link
Member

This isn't a conversation specific to Swift. We shouldn't boneyard things that aren't unsupported by upstream, are still installed by users and run on at least 1-2 of our supported OS versions.

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 25, 2016

This isn't a conversation specific to Swift.

Well it is, or at least I'm not arguing about anything else. Swift is special in that it is provided by Apple, and is already installed by either Xcode or CLT, which we require at least one. If we can keep it up to date then sure, but it has been having trouble for a long time and no one bothered to fix it.

What we support is ultimately decided by what is feasible for the team to support (including what outside help we can solicit), not what non-contributing users wish for. Also, in this case I doubt anyone cares about the removal of the swift formula.

@MikeMcQuaid
Copy link
Member

Also, in this case I doubt anyone cares about the removal of the swift formula.

I care about the removal of things that aren't unsupported by upstream, are still installed by users and run on at least 1-2 of our supported OS versions.

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 25, 2016

What people are running (suppose they're actually running it) is an outdated version.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants