-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swift: migrate to boneyard #6268
Conversation
Why? |
Swift is provided by Apple through Xcode or CLT. Not many people install this formula, nothing depends on it, no one cared to bring it to 3.0, and the last time I tried to bring it up-to-date with this patch it errored out in a non-obvious way. Lacking demand and enthusiasm, let just make it history. |
@MikeMcQuaid I was just about to CC you since you originally added it. |
We're running a pretty old release that's probably worth trying to upgrade. |
See comment above. If you can get it to work then sure. |
My patch is a starting point: https://gist.github.com/zmwangx/0075ced732314f1902bdc12ef6e720e4. |
Given we've got some people installing/using this: 👎 on removing. |
Then bring it to 3.0. |
@MikeMcQuaid I take that to mean you'll fix it? Because I've done my fair share of work to update it, and don't plan to waste more human and CPU time on something with little return (the official channel is better). I also don't want to see swift in #5488 forever. |
Not necessarily but I'll take a look.
That's up to you (as my work is up to me). We shouldn't boneyard things people are using. I won't object when no-one is using them.
A maximum macOS requirement is the best short-term fix for these cases, I think. |
Running Even if there are people using it, there's always |
This isn't a conversation specific to Swift. We shouldn't boneyard things that aren't unsupported by upstream, are still installed by users and run on at least 1-2 of our supported OS versions. |
Well it is, or at least I'm not arguing about anything else. Swift is special in that it is provided by Apple, and is already installed by either Xcode or CLT, which we require at least one. If we can keep it up to date then sure, but it has been having trouble for a long time and no one bothered to fix it. What we support is ultimately decided by what is feasible for the team to support (including what outside help we can solicit), not what non-contributing users wish for. Also, in this case I doubt anyone cares about the removal of the swift formula. |
I care about the removal of things that aren't unsupported by upstream, are still installed by users and run on at least 1-2 of our supported OS versions. |
What people are running (suppose they're actually running it) is an outdated version. |
Created with
brew boneyard-formula-pr
.