Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makepkg: fix build #6402

Closed
wants to merge 1 commit into from
Closed

Conversation

zmwangx
Copy link
Contributor

@zmwangx zmwangx commented Oct 29, 2016

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Without docbook-xsl and the corresponding XML_CATALOG_FILES in the environment, xsltproc(1) attempts to load .xsl files — e.g., http://docbook.sourceforge.net/release/xsl/current/html/lists.xsl — from the Internet, and when the build is parallelized, that is, multiple xsltproc processes attempt to fetch the same .xsl file at the same time and presumably write to the same location, a race condition is triggered and all processes exit with status 5.

An alternative fix is ENV.deparallelize (at least during make docs), but having to fetch .xsl files on the go and thus preventing offline builds is probably something to be frowned upon.
#6408.

Without docbook-xsl and the corresponding XML_CATALOG_FILES in the
environment, xsltproc(1) attempts to load .xsl files, e.g.,
http://docbook.sourceforge.net/release/xsl/current/html/lists.xsl, from
the Internet, and when the build is parallelized, that is, multiple
xsltproc processes attempt to fetch the same .xsl file at the same time
and presumably write to the same location, a race condition is triggered
and all processes exit with status 5.

An alternative fix is ENV.deparallelize, but having to fetch .xsl files
on the go and thus preventing offline builds is probably something to be
frowned upon.
@nijikon nijikon closed this in 4481c93 Oct 30, 2016
@zmwangx zmwangx deleted the makepkg-fix-build branch October 30, 2016 10:26
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant