Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snag: Set GO111MODULE=auto for Go 1.16 #71685

Merged
merged 1 commit into from
Feb 22, 2021
Merged

snag: Set GO111MODULE=auto for Go 1.16 #71685

merged 1 commit into from
Feb 22, 2021

Conversation

abhinav
Copy link
Contributor

@abhinav abhinav commented Feb 21, 2021 •
edited
Loading

This will allow this package to build with Go 1.16.

Epic: #47627
Upstream issue: Tonkpils/snag#66

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@abhinav
snag: Set GO111MODULE=auto for Go 1.16
41a8582 
This will allow this package to build with Go 1.16.

Epic: #47627
@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle labels Feb 21, 2021
@carlocab carlocab mentioned this pull request Feb 22, 2021
Closed
@carlocab
Copy link
Member

Thanks for your PR, @abhinav. Please report this upstream and link the report here.

See #71676 for an example.

@carlocab carlocab added automerge-skip `brew pr-automerge` will skip this pull request bottle unneeded [DEPRECATED] Bottle does not need to be built labels Feb 22, 2021
@abhinav
Copy link
Contributor Author

abhinav commented Feb 22, 2021

Whoops. Done.

@chenrui333 chenrui333 merged commit 18bd000 into Homebrew:master Feb 22, 2021
@abhinav abhinav deleted the go116/snag branch February 22, 2021 07:25
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 25, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request bottle unneeded [DEPRECATED] Bottle does not need to be built go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhinav @carlocab @chenrui333 @BrewTestBot