Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs regarding BAKE_VARIABLES config #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nmarinel
Copy link
Contributor

BAKE_VARIABLES is actually meant to be a path to a YAML file, not a string of JSON.

Here is where help describes the setting as a path and here is where the parsing happens.

@nmarinel
Copy link
Contributor Author

btw this came up because not having this set causes an error in the Kubernetes ingredient here. This probably qualifies as an issue - that _ctx.Environment.variables is completely undefined when the variables file isn't specified, but when an empty file is specified then _ctx.Environment.variables is populated with recipe data from the bake.yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant