Skip to content

Commit

Permalink
Casting bound values as float in inference_parameter.py to preven…
Browse files Browse the repository at this point in the history
…t parsing errors (#405)

* Update `inference_parameter.py`

Cast `lb` and `ub` as `floats` when they are pulled from the config.

* Implementing Joseph's suggestion

* Update `inference_parameter.py`
  • Loading branch information
emprzy authored Dec 6, 2024
1 parent 48c2425 commit b32cad8
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions flepimop/gempyor_pkg/src/gempyor/inference_parameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ def add_modifier(self, pname, ptype, parameter_config, subpops):
pname=pname,
subpop=sp,
pdist=parameter_config["value"].as_random_distribution(),
lb=parameter_config["value"]["a"].get(),
ub=parameter_config["value"]["b"].get(),
lb=parameter_config["value"]["a"].get(float),
ub=parameter_config["value"]["b"].get(float),
)

# grouped subpop have one parameter per group
Expand All @@ -67,8 +67,8 @@ def add_modifier(self, pname, ptype, parameter_config, subpops):
pname=pname,
subpop=",".join(group),
pdist=parameter_config["value"].as_random_distribution(),
lb=parameter_config["value"]["a"].get(),
ub=parameter_config["value"]["b"].get(),
lb=parameter_config["value"]["a"].get(float),
ub=parameter_config["value"]["b"].get(float),
)
elif parameter_config["method"].get() == "MultiPeriodModifier":
affected_subpops_grp = []
Expand Down Expand Up @@ -97,8 +97,8 @@ def add_modifier(self, pname, ptype, parameter_config, subpops):
pname=pname,
subpop=sp,
pdist=parameter_config["value"].as_random_distribution(),
lb=parameter_config["value"]["a"].get(),
ub=parameter_config["value"]["b"].get(),
lb=parameter_config["value"]["a"].get(float),
ub=parameter_config["value"]["b"].get(float),
)

# grouped subpop have one parameter per group
Expand All @@ -109,8 +109,8 @@ def add_modifier(self, pname, ptype, parameter_config, subpops):
pname=pname,
subpop=",".join(group),
pdist=parameter_config["value"].as_random_distribution(),
lb=parameter_config["value"]["a"].get(),
ub=parameter_config["value"]["b"].get(),
lb=parameter_config["value"]["a"].get(float),
ub=parameter_config["value"]["b"].get(float),
)
else:
raise ValueError(f"Unknown method {parameter_config['method']}")
Expand Down

0 comments on commit b32cad8

Please sign in to comment.