Casting bound values as float in inference_parameter.py to prevent parsing errors
#405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast `lb` and `ub` as `floats` when they are pulled from the config.
TimothyWillard
added
bug
jcblemai
reviewed
Dec 3, 2024
jcblemai
approved these changes
Dec 5, 2024
saraloo
reviewed
Dec 5, 2024
| @@ -53,8 +53,8 @@ def add_modifier(self, pname, ptype, parameter_config, subpops): | |||
| pname=pname, | |||
| subpop=sp, | |||
| pdist=parameter_config["value"].as_random_distribution(), | |||
| lb=parameter_config["value"]["a"].get(), | |||
| ub=parameter_config["value"]["b"].get(), | |||
| lb=float(parameter_config["value"]["a"].get()), | |||
There was a problem hiding this comment.
Is there a specific reason this is of a different form to lines 68 and 69? Otherwise I think this will deal with the error. thanks!
There was a problem hiding this comment.
Oops nope, just fixed them so that they match. Good catch
|
Two quick things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes.
Casting
lbandubvalues as floats within the.add_single_parameter()method.Does this pull request make any user interface changes? If so please describe.
N/A
What does your pull request address? Tag relevant issues.
This pull request addresses GH #380. Instances of scientific notation in configs that don't have a decimal in the mantissa AND a sign in the exponent are read in as strings (as opposed to floats), and this circumvents that.
Tag relevant team members.
@saraloo , is this adequate enough to prevent parsing errors? Perhaps there is somewhere else in this file (or places in other files) that needs a
float()cast as well?