Ops UX Improvements To Install And Init #419
Open
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the `.sh` extension from `hpc_init.sh` and `hpc_install_or_update.sh` to clarify that these are executables that should be ran directly by the user.
TimothyWillard
added
documentation
|
|
TimothyWillard
added
the
next release
TimothyWillard
requested review from
pearsonca,
fang19911030,
saraloo,
twallema,
MacdonaldJoshuaCaleb and
emprzy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes.
This pull request:
flepiMoPEnvironment documentation, andDoes this pull request make any user interface changes? If so please describe.
The user interface changes are how the
hpc_install_or_update&hpc_initscripts are invoked. Previously it was (assuming inflepiMoPrepository):Now this is done with:
Those are reflected in updates to the documentation in the Running On A HPC With Slurm
documentation. Edits can be seen here: https://github.com/HopkinsIDD/flepiMoP/blob/ad936917742da2db7fe633b17e5bf125e113c35d/documentation/gitbook/how-to-run/advanced-run-guides/running-on-a-hpc-with-slurm.md.
What does your pull request address? Tag relevant issues.
This pull request addresses GH-417 and #375 (comment).
Tag relevant team members.
@pearsonca, @saraloo