-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ops UX Improvements To Install And Init #419
base: dev
Are you sure you want to change the base?
Ops UX Improvements To Install And Init #419
Conversation
Removed the `.sh` extension from `hpc_init.sh` and `hpc_install_or_update.sh` to clarify that these are executables that should be ran directly by the user.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how useful this would actually be because longleaf and rockfish are so specific to their respective institutions, but does it potentially add any value to include relevant notes on how to configure those things/links to UNC/JHU based instructions for those?
I don't quite follow, add links to what? There is a documentation page already that covers how to use these scripts: https://iddynamics.gitbook.io/flepimop/how-to-run/advanced-run-guides/running-on-a-hpc-with-slurm, so I don't think adding links to the output of the scripts would be helpful. Do you mean adding links to that documentation to get setup on those HPCs? |
Describe your changes.
This pull request:
flepiMoP
Environment documentation, andDoes this pull request make any user interface changes? If so please describe.
The user interface changes are how the
hpc_install_or_update
&hpc_init
scripts are invoked. Previously it was (assuming inflepiMoP
repository):Now this is done with:
Those are reflected in updates to the documentation in the Running On A HPC With Slurm
documentation. Edits can be seen here: https://github.com/HopkinsIDD/flepiMoP/blob/ad936917742da2db7fe633b17e5bf125e113c35d/documentation/gitbook/how-to-run/advanced-run-guides/running-on-a-hpc-with-slurm.md.
What does your pull request address? Tag relevant issues.
This pull request addresses GH-417 and #375 (comment).
Tag relevant team members.
@pearsonca, @saraloo