-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test_cli.py #242
Update test_cli.py #242
Conversation
Added a function to test inference_main.R
I changed a typo in the code. Still failing. Will take another look later |
Attempting to fix error
Yes @emprzy , this is enough (no need to change the ci.yml). The test fails because inference_main calls inference_slot on the wrong path, because FLEPI_PATH is not set. Add to your command line: |
including `--FLEPI_PATH` so that inference_main can find inference_slot
Same thing
-- flepi_path ../../ addition to the end of the CL command
The tests are failing because of #197 |
@emprzy did this get merged or not ? this seems very useful ? |
Ah, I forgot about this PR. This is totally my fault because I did a horrible job properly documenting within the actual PR, but do you know what this was intended to address? |
This was adding a test of the R inference as part of the automatic test suite, I can look in ways to finish it, I think it was failing because it was blocked by another issue which is now resolved. Perhaps it even works now without doing anything. Let's see. |
I recommend close this PR, but don't chuck the branch. Once we've dealt with #336, I'm planning to integrate inference into the CLI, including support to use the R scripts. The skeleton here will be useful, but the core invocation is going to be different. |
@emprzy @pearsonca I think this PR has fallen quite a way behind |
I'll grab the inference test into my work on |
I'm very much in favor of closing it. I think perhaps we should check with @jcblemai though? |
@jcblemai is not going to be as involved day-to-day, I think we are safe closing this without waiting. |
I am curious if this is all that I needed to do. I changed some other things (inlcuding adding a clause in ci.yml) that I thought would be necessary, but upon second thought I deleted them because I suspected them to be unnecessary.
Now, the only change here is that I added the function we talked about to test_cli.py.
Please let me know what changes need to be made, if any.