Remove Dead Methods From gempyor.parameters.Parameters
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the `picklable_lamda_alpha` and `picklable_lamda_sigma` methods from the `Parameters` class.
TimothyWillard
added
gempyor
jcblemai
approved these changes
Dec 9, 2024
TimothyWillard
added
the
next release
TimothyWillard
requested review from
jcblemai,
pearsonca,
fang19911030 and
emprzy
jcblemai
approved these changes
Dec 12, 2024
emprzy
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes.
This PR removes the
picklable_lamda_alpha/sigmamethods from theParametersclass. These methods are not used anywhere in theflepiMoPcodebase.Does this pull request make any user interface changes? If so please describe.
Yes this removes two methods that were previously publicly accessible.
What does your pull request address? Tag relevant issues.
This pull request helps to address GH-276.