Skip to content

Commit

Permalink
Revert "graphql: fix an issue of nil pointer panic (ethereum#28416)"
Browse files Browse the repository at this point in the history
This reverts commit 503c8d4.
  • Loading branch information
devopsbo3 authored Nov 10, 2023
1 parent 36c650f commit 203bd00
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
3 changes: 0 additions & 3 deletions graphql/graphql.go
Original file line number Diff line number Diff line change
Expand Up @@ -1325,9 +1325,6 @@ func (r *Resolver) Blocks(ctx context.Context, args struct {
From *Long
To *Long
}) ([]*Block, error) {
if args.From == nil {
return nil, errors.New("from block number must be specified")
}
from := rpc.BlockNumber(*args.From)

var to rpc.BlockNumber
Expand Down
5 changes: 0 additions & 5 deletions graphql/graphql_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,6 @@ func TestGraphQLBlockSerialization(t *testing.T) {
want: `{"data":{"block":{"number":"0xa","call":{"data":"0x","status":"0x1"}}}}`,
code: 200,
},
{
body: `{"query": "{blocks {number}}"}`,
want: `{"errors":[{"message":"from block number must be specified","path":["blocks"]}],"data":null}`,
code: 400,
},
} {
resp, err := http.Post(fmt.Sprintf("%s/graphql", stack.HTTPEndpoint()), "application/json", strings.NewReader(tt.body))
if err != nil {
Expand Down

0 comments on commit 203bd00

Please sign in to comment.