Qa test #5
Qa test #5
Conversation
qa/README.md
Outdated
| **Requirements** | ||
|
|
||
| - Install Python 2.7 | ||
| - Donwload Sidechain SDK |
| return start_sc_nodes(self.number_of_sidechain_nodes, self.options.tmpdir, None, None, path) | ||
|
|
||
| #spends initial forgin stake to create a stadard coinbox | ||
| def convertInitialForging(self): |
There was a problem hiding this comment.
Instead of spending initial forging stake I would suggest to make a forward transfer.
If you will spend the stake and will not create another one, than in 2 epochs there will be no stakes registered for forging, so will not be able to produce new sc blocks.
| APP_JAR: sidechain app jar | ||
| APP_LIB: sidechain app lib folder | ||
| APP_MAIN: main sidechain class to run | ||
| SIDECHAIN_SDK: path to SDK folder |
There was a problem hiding this comment.
Seems, that we need to extract STF and Bootstaping tool to the separate git repo. Keep them generalized and let to set them as a submodules. So no need to copy that sources or keep SDK. Moreover it will let developers to fork these modules and change depends on their needs.
What do you think about this?
There was a problem hiding this comment.
I agree could be good to separate them from the SDK , since both the SDK and customer apps will use them for testing.
do you know how submodules loading works in python ? maybe we need anyway to set an env variable to the module
There was a problem hiding this comment.
I think, that we can use a git submodule, so the code folder will be placed in the place specified by the sidechain developer for his specific project.
There was a problem hiding this comment.
yes, could be ok, in this way we can use relative path in python import
- fixed typo in readme
Added general QA ttest structure, based on the SidechainSDKTest framework, with a couple of example-tests based on the lambo-registry workflow.
NOTE: requires changes detailed in this issue to be run correctly: HorizenOfficial/Sidechains-SDK#197