Layerzero OFT

[andreanistico]

https://horizenlabs.atlassian.net/browse/HZN-2116

Chain is: APECHAIN CURTIS TESTNET
Other chain is: ARBITRUM SEPOLIA TESTNET

─$ npx hardhat run ./scripts/deploy-multichain.ts --network curtis

Deploying Chain Token (ZenNativeOFT)
Chain token address: 0x742ae08ab454b3022C6E5f90c53073c2B8741feB
Deploying Other Chain Token (OtherSideOFT)
Other Chain token address: 0x916352E3b55D517bB9Dd74F7734761E9292eAC6c
Linking on chain token
waiting for tx: 0x3ff29674cc17e26a6181acdf3271ca4ea2db9daf9c9db075602cee2aee42f643
Other chain token set as remote on chain token.
linking on other chain token
waiting for tx: 0x0d27a531a60110b597cf8b651682829748fb67442120440ed7484f93b8f6d8b8
Chain token set as remote on other chain token.

─$ npx hardhat run ./scripts/demo-transfer.ts --network curtis

retrieving balances
native balance on chain: 999922978598523749
token balance on other chain: 0
transfer amount: 10
quote returned [{"type":"BigNumber","hex":"0x027e1bce8beb218c"},{"type":"BigNumber","hex":"0x00"}]
waiting for tx: 0x12fbc4898944d7e675cfc2128503507f8e59b5e71fc8cd7e82f7eeebbd9f8728
retrieving balances
native balance on chain: 820309097361365793
token balance on other chain: 0			

tx on layer zero scan
https://testnet.layerzeroscan.com/address/0x742ae08ab454b3022c6e5f90c53073c2b8741feb

[andreanistico]

Here worked better with APE delivered successully https://testnet.layerzeroscan.com/tx/0xfe08e0d46b05a04416531e806413d8a8d66feabcdd81bc222fc1975b6a2e0e90

Here there is the reverse (demo-transfer-2.ts) https://testnet.layerzeroscan.com/tx/0x1dd734bbc47173ee546c768faf8863441d33fd956f2bc59c1e13314e2bdb6f3b

[cbonaco1]

just curious why we are overriding some of these functions if they are inherited from LayerZero's OFT contract

[andreanistico]

In this case, it's because we invoke the custom _lzSendWithAmount instead of _lsZend
I can't simply override the _lzSend`` because I had to add the parameter amount, that it was not explicitely inserted before. Same for _payNative, the original one doesn't check that msg.value` is amount + fee because the original isn't developed for auto-wrapping native tokens.

Similar for _credit, it is overriden since it has to send native token instead of minting erc20 token

[cbonaco1]

makes sense. just curious why we need to pass the amount explicitly and not use msg.sender?