Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables sending HTML emails and "resume from crash" #49

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

boredsquirrel
Copy link
Contributor

@boredsquirrel boredsquirrel commented May 13, 2024

Description

removing unneeded lines and changing some settings:

  • allow sending mails only when HTML-specific things are actually done
  • remove anything regarding "debloat" (Thunderbird news are not bloat...)
  • enable accessibility (this can still be disabled but it is important for usability)
  • resume from crash
  • show condensed address only when in addressbook (this is no spam risk, and TB has GUI configs for that)
  • collect addresses of people you write. Mail is not anonymous and stores data, this will make spam detection easier etc
  • display inline images etc, this is very limited with sanitized HTML
  • allow extracting calendar events, this is by choice via a popup
  • enable the new tab page, makes no sense in TB

Reason and / or context

keep it minimal, dont force unnecessary things on users, making updating complicated

How has this been tested ?

Thunderbird Flatpak

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)

Checklist :

  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (see .eslintrc.yml).

allow sending mails only when HTML-specific things are actually done

remove anything regarding "debloat" (Thunderbird news are not bloat...)

enable accessibility

resume from crash

show condensed address only when in addressbook (this is no spam risk, and TB has GUI configs for that)

collect addresses of people you write. Mail is not anonymous and stores data, this will make spam detection easier etc

display inline images etc, this is very limited with sanitized HTML

allow extracting calendar events, this is by choice via a popup

enable the new tab page, makes no sense in TB
@boredsquirrel
Copy link
Contributor Author

this also affects this wiki entry

https://github.com/HorlogeSkynet/thunderbird-user.js/wiki/4.1.1-Calendar

when merged, the "extract calendar event" doesnt have to be mentioned, if it is removed, then it should.

I used TB without any hardening for a while and trust me, this feature is very fine.

@HorlogeSkynet HorlogeSkynet self-requested a review May 13, 2024 19:22
@HorlogeSkynet HorlogeSkynet self-assigned this May 13, 2024
@HorlogeSkynet HorlogeSkynet added the enhancement New feature or request label May 13, 2024
@boredsquirrel
Copy link
Contributor Author

accessibility actually seems to be about strange antivirus tools, I will disable it again

also updated the URL
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
Copy link
Owner

@HorlogeSkynet HorlogeSkynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same here, thanks 🙏)


I'm afraid I couldn't get what you meant by :

this also affects this wiki entry

Wiki: 4.1.1 Calendar ()

when merged, the "extract calendar event" doesnt have to be mentioned, if it is removed, then it should.

@boredsquirrel
Copy link
Contributor Author

@HorlogeSkynet If the calendar event extraction stuff would not be disabled in the config, then the wiki entry would not be needed anymore.

@HorlogeSkynet
Copy link
Owner

If the calendar event extraction stuff would not be disabled in the config, then the wiki entry would not be needed anymore.

I read the wiki page again and can't find any reference to "event extraction" feature (sorry if I didn't get you again)

HorlogeSkynet
HorlogeSkynet previously approved these changes Jul 9, 2024
@HorlogeSkynet HorlogeSkynet changed the title remove unneeded changes Enables sending HTML emails and "resume from crash" Jul 9, 2024
@HorlogeSkynet HorlogeSkynet merged commit 48529d1 into HorlogeSkynet:master Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants