Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce secure autoconfig and fetching from Exchange #50

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

boredsquirrel
Copy link
Contributor

Description

  • enable autoconfig
  • allow fetching from Exchange (needed for... exchange servers)
  • do not empty the autoconfig and Addon URLs as this is irreversible
  • add 2 hardening settings and enable them (even though "fetch from ISP" is still disabled)

Reason and / or context

Autoconfig is very useful and not critical, as it contacts the mailserver only, to get infos.

Contacting the ISP, or sending personal data is disabled, and the connection needs to be secure.

How has this been tested ?

yes, on Thunderbird Flatpak.

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist :

  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (see .eslintrc.yml).

@HorlogeSkynet HorlogeSkynet self-requested a review May 13, 2024 19:23
@HorlogeSkynet HorlogeSkynet self-assigned this May 13, 2024
@HorlogeSkynet HorlogeSkynet added the enhancement New feature or request label May 13, 2024
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Show resolved Hide resolved
Copy link
Owner

@HorlogeSkynet HorlogeSkynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find my comments inline. Thanks for your time 🙏

@boredsquirrel
Copy link
Contributor Author

Hi, sorry for the late reply. Added most changes that are clear to me.

so, deactivated but useful settings get no indentation, deactivated and obsolete settings get an indentation?

@HorlogeSkynet
Copy link
Owner

Hi, sorry for the late reply.

Hey, sorry too. I'll try to review all subjects in a batch again.

so, deactivated but useful settings get no indentation, deactivated and obsolete settings get an indentation?

Disabled preferences are always indented. Enabled ones aren't.
Deprecated (upstream) settings follow the same rule.

user.js Outdated Show resolved Hide resolved
@HorlogeSkynet HorlogeSkynet self-requested a review July 9, 2024 19:44
@HorlogeSkynet HorlogeSkynet changed the title enable secure autoconfig Enforce secure autoconfig and fetching from Exchange Jul 9, 2024
@HorlogeSkynet HorlogeSkynet merged commit 824edab into HorlogeSkynet:master Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants