Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert .bat scripts to CRLF line-ending #59

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

phongse
Copy link
Contributor

@phongse phongse commented Nov 8, 2024

Description

.bat files on Windows is sensitive to line-endings and using LF causes unintended runtime behavior such as not being able to download user.js.new, not following a linear runtime but branching out in other parts of the script.

I converted both scripts to use CRLF endings, a typo in setting the _version variable and properly detecting thunderbird user.js _name.

Reason and / or context

Fix unintended behavior in the scripts.

How has this been tested ?

Tested both scripts with default setup, no special flags passed to the scripts.

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (see .eslint.config.mjs).

updater.bat Show resolved Hide resolved
updater.bat Show resolved Hide resolved
updater.bat Show resolved Hide resolved
updater.bat Show resolved Hide resolved
@HorlogeSkynet HorlogeSkynet added the bug Something isn't working label Nov 9, 2024
HorlogeSkynet added a commit to HorlogeSkynet/user.js that referenced this pull request Nov 9, 2024
@HorlogeSkynet HorlogeSkynet self-requested a review November 9, 2024 15:13
@HorlogeSkynet HorlogeSkynet merged commit 4d986ff into HorlogeSkynet:master Nov 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants