Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Validations for weather search #105

Merged
merged 3 commits into from
Oct 4, 2023
Merged

[fix] Validations for weather search #105

merged 3 commits into from
Oct 4, 2023

Conversation

vatsalsinghkv
Copy link
Contributor

Fixes #76

  • Installed react toasts (for alerting).
  • Fixed so empty string cannot be searched for weather
  • Fixed so empty string cannot be searched for countries

@netlify
Copy link

netlify bot commented Oct 3, 2023 •
edited
Loading

✅ Deploy Preview for effulgent-brioche-795ac4 ready!

Name Link
🔨 Latest commit bb85c0f
🔍 Latest deploy log https://app.netlify.com/sites/effulgent-brioche-795ac4/deploys/651d44acedd3ec00084208c1
😎 Deploy Preview https://deploy-preview-105--effulgent-brioche-795ac4.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Oct 3, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@HridoyHazard
Copy link
Owner

@vatsalsinghkv resolve the conflict plz

@vatsalsinghkv
Copy link
Contributor Author

@HridoyHazard Fixed

@HridoyHazard HridoyHazard merged commit 9f49bd7 into HridoyHazard:main Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HridoyHazard HridoyHazard HridoyHazard approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No Validations
2 participants
@vatsalsinghkv @HridoyHazard