Skip to content

Commit

Permalink
address prometheus/client_model change and fix flaky test
Browse files Browse the repository at this point in the history
  • Loading branch information
Hsn723 committed Jan 29, 2024
1 parent c416212 commit d316443
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ postfix_exporter
*.iml
vendor/
dist/
cover.out
17 changes: 9 additions & 8 deletions postfix_exporter_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package main

import (
"strings"
"testing"

"github.com/prometheus/client_golang/prometheus"
Expand Down Expand Up @@ -237,9 +238,9 @@ func TestPostfixExporter_CollectFromLogline(t *testing.T) {
"Mar 16 23:30:44 123-mail postfix/qmgr[29980]: warning: lots of deferred mail, that is bad for performance",
},
unsupportedLogEntries: []string{
`label:<name:"level" value:"" > label:<name:"service" value:"smtpd" > counter:<value:1 > `,
`label:<name:"level" value:"fatal" > label:<name:"service" value:"smtpd" > counter:<value:1 > `,
`label:<name:"level" value:"warning" > label:<name:"service" value:"qmgr" > counter:<value:2 > `,
`label:{name:"level" value:""} label:{name:"service" value:"smtpd"} counter:{value:1}`,
`label:{name:"level" value:"fatal"} label:{name:"service" value:"smtpd"} counter:{value:1}`,
`label:{name:"level" value:"warning"} label:{name:"service" value:"qmgr"} counter:{value:2}`,
},
},
fields: fields{
Expand Down Expand Up @@ -308,7 +309,7 @@ func assertCounterEquals(t *testing.T, counter prometheus.Collector, expected in
var count int = 0
for metric := range metricsChan {
metricDto := io_prometheus_client.Metric{}
metric.Write(&metricDto)
_ = metric.Write(&metricDto)
count += int(*metricDto.Counter.Value)
}
assert.Equal(t, expected, count, message)
Expand All @@ -321,7 +322,7 @@ func assertCounterEquals(t *testing.T, counter prometheus.Collector, expected in
var count int = 0
for metric := range metricsChan {
metricDto := io_prometheus_client.Metric{}
metric.Write(&metricDto)
_ = metric.Write(&metricDto)
count += int(*metricDto.Counter.Value)
}
assert.Equal(t, expected, count, message)
Expand All @@ -340,9 +341,9 @@ func assertVecMetricsEquals(t *testing.T, counter *prometheus.CounterVec, expect
var res []string
for metric := range metricsChan {
metricDto := io_prometheus_client.Metric{}
metric.Write(&metricDto)
res = append(res, metricDto.String())
_ = metric.Write(&metricDto)
res = append(res, strings.Replace(metricDto.String(), " ", " ", -1))
}
assert.Equal(t, expected, res, message)
assert.ElementsMatch(t, expected, res, message)
}
}

0 comments on commit d316443

Please sign in to comment.