Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger events when broadcast message is received #263

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Trigger events when broadcast message is received #263

merged 1 commit into from
Jan 17, 2025

Conversation

esme
Copy link
Contributor

@esme esme commented Jan 16, 2025 •
edited
Loading

Description

https://git.hubteam.com/HubSpot/calling-extensions-fe/issues/985

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix? yes
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-263/

Built to branch gh-pages at 2025-01-17 19:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@esme esme force-pushed the fix-event-handlers branch from e854980 to b3ba4d3 Compare January 17, 2025 19:49
@esme esme force-pushed the fix-event-handlers branch from b3ba4d3 to e15d7d9 Compare January 17, 2025 19:51
@esme esme marked this pull request as ready for review January 17, 2025 19:52
@esme esme requested a review from a team as a code owner January 17, 2025 19:52
@esme
Copy link
Contributor Author

esme commented Jan 17, 2025

@hemang-thakkar This is related to the usesCallingWindow=false changes

@esme esme requested a review from hemang-thakkar January 17, 2025 20:01
@esme
Copy link
Contributor Author

esme commented Jan 17, 2025

@hemang-thakkar Attached a video for your reference
2025-01-17 12 02 02

hemang-thakkar
hemang-thakkar approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@hemang-thakkar hemang-thakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esme esme merged commit 64ac910 into master Jan 17, 2025
1 check passed
@esme esme deleted the fix-event-handlers branch January 17, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemang-thakkar hemang-thakkar hemang-thakkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esme @hemang-thakkar