chore: Convert simple prompts to TypeScript #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
kemmerle
commented
Nov 26, 2024
| // Accounts for deprecated and new config | ||
| const defaultAccount = getConfigDefaultAccount(config); | ||
| const defaultAccount = getConfigDefaultAccount(); |
There was a problem hiding this comment.
getConfigDefaultAccount doesn't take any arguments--the power of TypeScript!
camden11
reviewed
Nov 26, 2024
kemmerle
commented
Nov 26, 2024
camden11
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
In this PR, I convert simple prompts to TypeScript. These include:
accountNamePrompt.tscleanUploadPrompt.tscreateFunctionPrompt.tscreateModulePrompt.tscreateTemplatePrompt.tsprojectsLogsPrompt.tssecretPrompt.tssetAsDefaultAccountPrompt.tsIMPORTANT: I was having trouble importing inquirer when converting prompts to TS. We're currently using inquirer v.8.2.0, which is a CommonJS module. We need to bump to the current version (v.12.1.0) to import it using ES module syntax.
Currently, we're wrapping inquirer.createPromptModule() in our helper function, promptUser. My gut feeling is that we should convert promptUser to inquirer.prompt in one PR, once all the files that consume promptUser are converted to TS. Is that a reasonable plan?
I don't see how we can support two inquirer versions (one CommonJS andv one ES module syntax), but let me know if that's possible/preferable.
TODO
inquirerWho to Notify
@camden11 @brandenrodgers @joe-yeager