-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the pagefind highlight script #54
Conversation
Also added the ability to customise the URL that pagefind is being imported from, instead of relying on the default import of /pagefind/pagefind.js. Updated the documentation to reflect this additional configuration option and fixed typos in the README.
da683d5
to
ddfbc90
Compare
Hey @hankertrix, thanks for the PR. This looks like a nice feature. Looks like the checks are failing, could you run |
Done as requested! |
0c6c21c
to
de5e6f8
Compare
Okay, I fixed everything in the build ci, somehow my LSP wasn't catching the errors. |
That could be because I use biome, instead of the more commonly used prettier + eslint. I find one tool easier. |
Ahhh I see, that might be it. Looks like all checks have passed! |
Yup, I will do a quick review probably tomorrow and aim to merge then! Thanks! |
@hankertrix Do you mind if I rename the configuration option to |
Oh yeah sure thing! |
233c609
to
3e4b4f4
Compare
3e4b4f4
to
5e932b1
Compare
I renamed the configuration option. |
Closing this in favour of #55, as that implements everything this pull request also implements. |
Also added the ability to customise the URL that pagefind is being imported from, instead of relying on the default import of
/pagefind/pagefind.js
.Updated the documentation to reflect this additional configuration option.
Also fixed a typo in the README,
offical
->official
.