Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the pagefind highlight script #54

Closed

Conversation

hankertrix
Copy link
Contributor

Also added the ability to customise the URL that pagefind is being imported from, instead of relying on the default import of /pagefind/pagefind.js.

Updated the documentation to reflect this additional configuration option.

Also fixed a typo in the README, offical -> official.

Also added the ability to customise the URL that pagefind is being
imported from, instead of relying on the default import of
/pagefind/pagefind.js.

Updated the documentation to reflect this additional configuration
option and fixed typos in the README.
@hankertrix hankertrix force-pushed the support-pagefind-highlight branch from da683d5 to ddfbc90 Compare November 20, 2024 07:52
@Hugos68
Copy link
Owner

Hugos68 commented Nov 20, 2024

Hey @hankertrix, thanks for the PR. This looks like a nice feature. Looks like the checks are failing, could you run pnpm check aswell as pnpm changeset to add a changeset? This can be a patch change.

@hankertrix
Copy link
Contributor Author

Done as requested!

@hankertrix hankertrix force-pushed the support-pagefind-highlight branch from 0c6c21c to de5e6f8 Compare November 21, 2024 09:27
@hankertrix
Copy link
Contributor Author

hankertrix commented Nov 21, 2024

Okay, I fixed everything in the build ci, somehow my LSP wasn't catching the errors.

@Hugos68
Copy link
Owner

Hugos68 commented Nov 21, 2024

That could be because I use biome, instead of the more commonly used prettier + eslint. I find one tool easier.

@hankertrix
Copy link
Contributor Author

Ahhh I see, that might be it.

Looks like all checks have passed!

@Hugos68
Copy link
Owner

Hugos68 commented Nov 21, 2024

Yup, I will do a quick review probably tomorrow and aim to merge then! Thanks!

@Hugos68
Copy link
Owner

Hugos68 commented Nov 21, 2024

@hankertrix Do you mind if I rename the configuration option to pagefind_dir? URL's usually point to files, so I feel like the name isn't instantly intuitive.

@hankertrix
Copy link
Contributor Author

@hankertrix Do you mind if I rename the configuration option to pagefind_dir? URL's usually point to files, so I feel like the name isn't instantly intuitive.

Oh yeah sure thing!

@hankertrix hankertrix force-pushed the support-pagefind-highlight branch from 233c609 to 3e4b4f4 Compare November 22, 2024 05:34
@hankertrix hankertrix force-pushed the support-pagefind-highlight branch from 3e4b4f4 to 5e932b1 Compare November 22, 2024 05:36
@hankertrix
Copy link
Contributor Author

I renamed the configuration option.

@hankertrix hankertrix closed this Dec 4, 2024
@hankertrix hankertrix deleted the support-pagefind-highlight branch December 4, 2024 10:07
@hankertrix
Copy link
Contributor Author

Closing this in favour of #55, as that implements everything this pull request also implements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants