Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-1886: Add o3-mini OpenAI model #325

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

hakan458
Copy link
Contributor

@hakan458 hakan458 commented Jan 31, 2025

o3-mini does not support max_tokens or temperature so making those params optional

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.81%. Comparing base (a913999) to head (99f4892).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files          47       47           
  Lines        2622     2622           
=======================================
  Hits         1752     1752           
  Misses        870      870           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot-ci-heartex robot-ci-heartex marked this pull request as draft February 1, 2025 10:05
@MihajloHoma MihajloHoma marked this pull request as ready for review February 3, 2025 12:36
@matt-bernstein matt-bernstein merged commit 8acdba7 into master Feb 3, 2025
22 checks passed
@matt-bernstein matt-bernstein deleted the fb-dia-1886 branch February 3, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants