Feature rights #91
Feature rights #91
Conversation
| @@ -0,0 +1,70 @@ | |||
| const Functionality = Val | |||
| const PATHBASE = "data/permissions/" | |||
There was a problem hiding this comment.
Can you use a more specific name that relates to permission?
|
|
||
| has_access(guid::Snowflake, member::Member, task::Functionality) = has_access(guid, member.roles, task) | ||
|
|
||
| function has_access(guid::Snowflake, roles::Vector{Snowflake}, ::Functionality{Task}) where Task |
There was a problem hiding this comment.
Perhaps it's time to graduate from using Val to an abstract type? So, you can just do T <: AbstractTask.
|
|
||
|
|
||
| function load() | ||
| isdir(PATHBASE) || return |
There was a problem hiding this comment.
Perhaps we should log a warning before returning?
| while !eof(io) | ||
| lensym = read(io, UInt8) | ||
| lenroles = read(io, UInt8) | ||
| sym = Symbol(read(io, lensym)) | ||
| roles = Set(reinterpret(Snowflake, read(io, lenroles))) | ||
| PERMISSIONS[sym] = roles | ||
| end |
There was a problem hiding this comment.
I'm not a fan of building custom SerDes. We are already using StructTypes and JSON3 and that's pretty easy. For example:
HoJBot.jl/src/command/discourse.jl
Lines 109 to 120 in 99076ee
If you choose to use custom data types:
HoJBot.jl/src/type/discourse.jl
Lines 59 to 61 in 99076ee
| end | ||
|
|
||
| function grant!(guid::Snowflake, role::Snowflake, ::Functionality{Task}) where Task | ||
| guildperms = PERMISSIONS[guid] |
There was a problem hiding this comment.
Don't shoot me 😄
| guildperms = PERMISSIONS[guid] | |
| guild_perms = PERMISSIONS[guid] |
| function handle_command end | ||
|
|
||
| "Entry point for a new observer plugin, triggers on almost all events related to text chat" | ||
| function handle_observer end #I suggest renaming handlers to observers since they act on observations |
| """GuildID->(Functionality->[permitted roles])""" | ||
| const PERMISSIONS = Dict{Snowflake,Dict{Symbol,Set{Snowflake}}}() |
There was a problem hiding this comment.
Can you move constant definitions to the top of file? See https://github.com/invenia/BlueStyle#global-variables
| open(joinpath(dir, string(guid))) do io | ||
| fguid = read(io, Snowflake) | ||
| if fguid != guid | ||
| @info "file conflict, tried to load $guid but got $fguid" |
This is a first trial on how to implement rights management solely bound to Guild Roles.