Skip to content

Commit

Permalink
Update Signal.js
Browse files Browse the repository at this point in the history
Fix for issue millermedeiros#67
  • Loading branch information
Hypercubed committed Jun 10, 2015
1 parent 1a82bdd commit 691ae4b
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/Signal.js
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,13 @@
if (! this.active) {
return;
}

var len = arguments.length, paramsArr = new Array(len);
for (var i=0; i < len; ++i) {
paramsArr[i] = arguments[i];
}

var paramsArr = Array.prototype.slice.call(arguments),
n = this._bindings.length,
var n = this._bindings.length,
bindings;

if (this.memorize) {
Expand Down

1 comment on commit 691ae4b

@Hypercubed
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v8 disables optimization for any method when the arguments variable is passed to other functions. Source: https://code.google.com/p/v8/issues/detail?id=3037

Please sign in to comment.