-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linked new ReactUI to Order --> Study --> Electronic Orders #1483
base: develop
Are you sure you want to change the base?
Conversation
Thank You @harshitg927 🙂 for rasing PR |
Sure @adityadeshlahre , I will look into the responsiveness of this page too, Thank You for your feedback. |
1e38cca
to
1e1ea47
Compare
@adityadeshlahre I have pushed the changes making the page responsive, Can you please review the changes that I have made, Thank You. |
@harshitg927 i will take a look and let you know! |
Thanks @harshitg927 Study electronic oder UI is mean to use the StudyElectronicOrderContoller . . So that should be writed as a Rest Controller |
{createDataTable(eOrders)} | ||
</div> | ||
)} | ||
|
||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put this in a separate css class ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
<FormattedMessage id="eorder.search.noresults" /> | ||
</Column> | ||
)} | ||
</Grid> | ||
</div> | ||
</> | ||
|
||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put this in a separate css class ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
dc6001e
to
0a775ad
Compare
@mozzy11 I made the requested changes, Please review them too. Thank You. |
681fe51
to
9da8ec0
Compare
formatted the frontend code using npm run format
9da8ec0
to
a1390e7
Compare
24ed4d5
to
4b4de7d
Compare
@@ -0,0 +1,57 @@ | |||
/* Container styles */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in overall code base we are avoiding the use of custom CSS please avoid the explicit use
Fixes: issue#1474
Fixes: issue#1532
Summary
The new React UI for StudyElectronicOrder was already written. I also wrote the REST Controller for this endpoint. So, in this Pull Request I went ahead and just linked them with the desired side navigation item
Screen Recording
Screencast.from.31-01-25.10.15.00.PM.IST.webm
Related Issue
#1474