Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked new ReactUI to Order --> Study --> Electronic Orders #1483

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

harshitg927
Copy link
Contributor

@harshitg927 harshitg927 commented Jan 31, 2025

Fixes: issue#1474
Fixes: issue#1532

Summary

The new React UI for StudyElectronicOrder was already written. I also wrote the REST Controller for this endpoint. So, in this Pull Request I went ahead and just linked them with the desired side navigation item

Screen Recording

Screencast.from.31-01-25.10.15.00.PM.IST.webm

Related Issue

#1474

@adityadeshlahre
Copy link
Contributor

adityadeshlahre commented Jan 31, 2025

image
image

Thank You @harshitg927 🙂 for rasing PR
if you time can fix the responsiveness issue on this page ??

@harshitg927
Copy link
Contributor Author

Sure @adityadeshlahre , I will look into the responsiveness of this page too, Thank You for your feedback.

@harshitg927
Copy link
Contributor Author

@adityadeshlahre I have pushed the changes making the page responsive, Can you please review the changes that I have made, Thank You.

@adityadeshlahre
Copy link
Contributor

@harshitg927 i will take a look and let you know!

@mozzy11
Copy link
Collaborator

mozzy11 commented Feb 5, 2025

Thanks @harshitg927 Study electronic oder UI is mean to use the StudyElectronicOrderContoller . . So that should be writed as a Rest Controller

{createDataTable(eOrders)}
</div>
)}

<style>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this in a separate css class ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<FormattedMessage id="eorder.search.noresults" />
</Column>
)}
</Grid>
</div>
</>

<style>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this in a separate css class ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@harshitg927
Copy link
Contributor Author

@mozzy11 I made the requested changes, Please review them too. Thank You.

@harshitg927 harshitg927 force-pushed the issue-1474 branch 2 times, most recently from 681fe51 to 9da8ec0 Compare February 7, 2025 14:46
formatted the frontend code using npm run format
@harshitg927 harshitg927 requested a review from mozzy11 February 18, 2025 10:02
@@ -0,0 +1,57 @@
/* Container styles */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in overall code base we are avoiding the use of custom CSS please avoid the explicit use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add New UI to Order/Study/ElectronicOrders Re-write Order ---> Study ---> Electronic Orders in new React UI
3 participants