turned off strict checking for the registry id

IABTechLab · Nov 28, 2023 · 43abfb7 · 43abfb7
1 parent 9ec615a
commit 43abfb7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/fideslang/models.py b/src/fideslang/models.py
@@ -1098,6 +1098,7 @@ class System(FidesModel):
     registry_id: Optional[int] = Field(
         default=None,
         description="The id of the system registry, if used.",
+        strict=False,  # This allows Pydantic to coerce '1' -> 1
     )
     meta: Optional[Dict] = meta_field
     fidesctl_meta: Optional[SystemMetadata] = Field(
@@ -1149,7 +1150,7 @@ class System(FidesModel):
         description="If specified, the unique identifier for the vendor that was previously associated with this system.",
     )
     dataset_references: Optional[List[FidesKey]] = Field(
-        default=None,
+        default=[],
         description="Referenced Dataset fides keys used by the system.",
     )
     processes_personal_data: bool = Field(

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -95,7 +95,7 @@ def resources_dict():
         ),
         "system": models.System(
             organization_fides_key="1",
-            registryId="1",
+            registry_id="1",
             fides_key="test_system",
             system_type="SYSTEM",
             name="Test System",

diff --git a/tests/fideslang/test_validation.py b/tests/fideslang/test_validation.py
@@ -404,7 +404,6 @@ def test_valid_policy():
         organization_fides_key="1",
         fides_key="test_policy",
         name="Test Policy",
-        version="1.3",
         description="Test Policy",
         rules=[],
     )
@@ -415,7 +414,7 @@ def test_valid_policy():
 def test_create_valid_system():
     System(
         organization_fides_key="1",
-        registryId="1",
+        registry_id=1,
         fides_key="test_system",
         system_type="SYSTEM",
         name="Test System",
@@ -446,7 +445,7 @@ def test_invalid_country_identifier(country_code: str):
     with pytest.raises(ValidationError):
         System(
             organization_fides_key="1",
-            registryId="1",
+            registry_id="1",
             fides_key="test_system",
             system_type="SYSTEM",
             name="Test System",
@@ -471,7 +470,7 @@ def test_valid_country_identifier(country_code: str):
     """Validates usage of alpha-3 codes per ISO 3166"""
     System(
         organization_fides_key="1",
-        registryId="1",
+        registry_id="1",
         fides_key="test_system",
         system_type="SYSTEM",
         name="Test System",