Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore personalize.profiling #174

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Restore personalize.profiling #174

merged 1 commit into from
Oct 6, 2023

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Oct 6, 2023 •
edited
Loading

Partially closes ethyca/fides#4226

This assumes a 2.1.1 release -

Description Of Changes

Update from https://github.com/ethyca/fideslang/pull/171

Restores personalize.profiling. Marks as deprecated instead of deleting altogether.

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps taken to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@pattisdr pattisdr changed the title Restore data use to taxonomy that was previously deleted, instead mar… Restore personalize.profiling Oct 6, 2023
@pattisdr pattisdr requested a review from adamsachs October 6, 2023 16:49
adamsachs
adamsachs approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good - wouldn't be surprised if we end up pulling it out sooner rather than later but let's do this for now 👍

@pattisdr pattisdr merged commit b039ca6 into main Oct 6, 2023
@pattisdr pattisdr deleted the restore_personalize_profiling branch October 6, 2023 17:58
@pattisdr pattisdr mentioned this pull request Oct 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorporate Purpose 11
2 participants
@pattisdr @adamsachs