-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gvl data category mapping and functions #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsachs
force-pushed
the
asachs/gvl-mapping-data-categories
branch
from
October 6, 2023 19:16
b08c184
to
8202212
Compare
adamsachs
commented
Oct 6, 2023
adamsachs
force-pushed
the
asachs/gvl-mapping-data-categories
branch
from
October 6, 2023 19:18
8202212
to
c440675
Compare
pattisdr
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful to see this moving to fideslang - mostly I have some comments about whether we want to make some slight edits to the raw text from the vendor list, but we can also match it too. Just pointing it out.
Co-authored-by: Dawn Pattison <[email protected]>
Co-authored-by: Dawn Pattison <[email protected]>
Co-authored-by: Dawn Pattison <[email protected]>
Co-authored-by: Dawn Pattison <[email protected]>
Co-authored-by: Dawn Pattison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
We've been using a GVL data category <--> fideslang data category mapping in our compass data generation scripts. it's time to move this mapping definition/function to fideslang.
Change here is purely additive and should be low-impact, so even if we need to tweak, shouldn't disrupt any other utilities 👍
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md