Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gvl data category mapping and functions #175

Merged
merged 6 commits into from
Oct 7, 2023

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Oct 6, 2023

Description Of Changes

We've been using a GVL data category <--> fideslang data category mapping in our compass data generation scripts. it's time to move this mapping definition/function to fideslang.

Change here is purely additive and should be low-impact, so even if we need to tweak, shouldn't disrupt any other utilities 👍

Code Changes

  • add GVL <--> fideslang data category mapping file
  • add and expose associated mapping functions

Steps to Confirm

  • list any manual steps taken to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@adamsachs adamsachs force-pushed the asachs/gvl-mapping-data-categories branch from b08c184 to 8202212 Compare October 6, 2023 19:16
@adamsachs adamsachs force-pushed the asachs/gvl-mapping-data-categories branch from 8202212 to c440675 Compare October 6, 2023 19:18
@adamsachs adamsachs marked this pull request as ready for review October 6, 2023 19:18
@adamsachs adamsachs requested a review from pattisdr October 6, 2023 19:18
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful to see this moving to fideslang - mostly I have some comments about whether we want to make some slight edits to the raw text from the vendor list, but we can also match it too. Just pointing it out.

src/fideslang/gvl/gvl_data_category_mapping.json Outdated Show resolved Hide resolved
src/fideslang/gvl/gvl_data_category_mapping.json Outdated Show resolved Hide resolved
src/fideslang/gvl/gvl_data_category_mapping.json Outdated Show resolved Hide resolved
src/fideslang/gvl/gvl_data_category_mapping.json Outdated Show resolved Hide resolved
src/fideslang/gvl/gvl_data_category_mapping.json Outdated Show resolved Hide resolved
@adamsachs adamsachs merged commit fac23a6 into main Oct 7, 2023
@adamsachs adamsachs deleted the asachs/gvl-mapping-data-categories branch October 7, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants