Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Level Cookies #181

Merged
merged 2 commits into from
Nov 6, 2023
Merged

System Level Cookies #181

merged 2 commits into from
Nov 6, 2023

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Nov 2, 2023 •
edited
Loading

Partially closes https://ethyca.atlassian.net/browse/PROD-1310

Description Of Changes

Add a new fideslang System property to support setting Cookies at the System level only that are unassociated with a data use.

Code Changes

  • Adds new System.cookies property. Note we already had this on the SystemResponse schema in Fides, where its meaning was cookies either on the PrivacyDeclaration or the System. We are changing the meaning of System.cookies here, so they are only cookies at the System level. If you want to attach a Cookie to a PrivacyDeclaration attach it there directly.

Steps to Confirm

  • list any manual steps taken to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@pattisdr pattisdr mentioned this pull request Nov 3, 2023
Merged
8 tasks
@pattisdr pattisdr requested a review from adamsachs November 3, 2023 20:04
adamsachs
adamsachs approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i'll also have a fideslang PR for previous_vendor_id shortly so i think we can hold off on publishing a release, unless it's necessary for dependent code

@pattisdr pattisdr merged commit f5ab584 into main Nov 6, 2023
31 checks passed
@pattisdr pattisdr deleted the PROD-1310_system_level_cookies branch November 6, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pattisdr @adamsachs