Adding more work on salt encryption #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasm-ttd
reviewed
Dec 10, 2024
|
|
||
| @Override | ||
| public StoreReader<Collection<RotatingSaltProvider.SaltSnapshot>> getReader(Integer siteId) { | ||
| return null; |
There was a problem hiding this comment.
Should these methods not throw, rather than return null? If we don't expect them to be called, they should at least throw so we catch the error earlier.
Or do we divide the interface so that the methods are not required here?
There was a problem hiding this comment.
Throwing would change the interface too. But I think splitting it up would also be annoying.
I am thinking when we continue with Admin rework, we migrate salts to follow the pattern of our other files and we can fill these in then.
There was a problem hiding this comment.
Ok, lets leave it as, but add logging (at WARN level) to indicate the method is being called.
thomasm-ttd
approved these changes
Dec 11, 2024
…ABTechLab/uid2-admin into cbc-UID2-4571-cloud-encryption-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.