Cbc UI d2 4571 cloud encryption cleanup #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasm-ttd
reviewed
Dec 10, 2024
src/main/java/com/uid2/shared/store/RotatingEncryptedSaltProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/uid2/shared/store/RotatingEncryptedSaltProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/uid2/shared/store/reader/RotatingCloudEncryptionKeyProvider.java
Outdated
Show resolved
Hide resolved
| import java.util.Collection; | ||
|
|
||
| public class RotatingEncryptedSaltProvider extends RotatingSaltProvider implements StoreReader<Collection<RotatingSaltProvider.SaltSnapshot>> { | ||
| private final RotatingCloudEncryptionKeyProvider cloudEncryptionKeyProvider; |
There was a problem hiding this comment.
There are no tests for this class - are you still adding them?
thomasm-ttd
approved these changes
Dec 11, 2024
Ian-Nara
reviewed
Dec 16, 2024
| @@ -33,6 +33,11 @@ public RotatingCloudEncryptionKeyProvider(DownloadCloudStorage fileStreamProvide | |||
| this.reader = new ScopedStoreReader<>(fileStreamProvider, scope, new CloudEncryptionKeyParser(), "cloud_encryption_keys"); | |||
| } | |||
|
|
|||
|
|
|||
| public RotatingCloudEncryptionKeyProvider(DownloadCloudStorage fileStreamProvider, StoreScope scope, ScopedStoreReader<Map<Integer, CloudEncryptionKey>> reader) { | |||
| this.reader = reader; | |||
There was a problem hiding this comment.
where do we use this version of the constructor?
There was a problem hiding this comment.
In tests, I did this as instead of making reader public.
Ian-Nara
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.