Skip to content

Commit

Permalink
Fix tasks & update readme
Browse files Browse the repository at this point in the history
- Fix volume for views
- Fix envFile -> envFiles
- Update README to specify AD_TAG_URL and remove double quotes
  • Loading branch information
alex-yau-ttd committed Sep 8, 2023
1 parent c5a9ba6 commit 42f4a58
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@
],
"volumes": [
{
"localPath": "${workspaceFolder}/examples/google-esp-integration/with_sdk_v3",
"containerPath": "/usr/share/nginx/html",
"localPath": "${workspaceFolder}/examples/google-esp-integration/with_sdk_v3/views",
"containerPath": "/usr/src/app/views",
"permissions": "ro"
}
],
"envFile": "${workspaceFolder}/examples/google-esp-integration/with_sdk_v3/.env",
"remove": true
"envFiles": ["${workspaceFolder}/examples/google-esp-integration/with_sdk_v3/.env"],
"remove": true,
}
},
{
Expand Down
11 changes: 6 additions & 5 deletions examples/google-esp-integration/with_sdk_v3/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ The easiest way to try the example is to do the following:
1. Open this repo in VS Code
1. Create a `.env` file in this folder and populate `UID2_API_KEY` and `UID2_CLIENT_SECRET`:
```
UID2_BASE_URL="http://localhost:8080"
UID2_JS_SDK_URL="http://localhost:9091/uid2-sdk.js"
UID2_API_KEY="<your-integ-API-key>"
UID2_CLIENT_SECRET="<your-integ-client-secret>"
UID2_BASE_URL=http://localhost:8080
UID2_API_KEY=<your-integ-API-key>
UID2_CLIENT_SECRET=<your-integ-client-secret>
AD_TAG_URL=https://pubads.g.doubleclick.net/gampad/ads?iu=/21775744923/extrernal/adx-test-tag&tfcd=0&npa=0&sz=640x480&gdfp_req=1&output=vast&unviewed_position_start=1&env=vp&impl=s&correlator=
UID2_JS_SDK_URL=http://localhost:9091/uid2-sdk.js
```
1. Click the Run and Debug tab or hit `Crtl+Shift+D`
1. Select `Launch ESP (Chrome)` from the configuration dropdown
Expand All @@ -33,7 +34,7 @@ docker run -it --rm -p 3000:3000 \
-e UID2_BASE_URL="https://operator-integ.uidapi.com" \
-e UID2_API_KEY="<your-integ-API-key>" \
-e UID2_CLIENT_SECRET="<your-integ-client-secret>" \
-e AD_TAG_URL="<your-IMA-ad-tag-url>" \
-e AD_TAG_URL="https://pubads.g.doubleclick.net/gampad/ads?iu=/21775744923/extrernal/adx-test-tag&tfcd=0&npa=0&sz=640x480&gdfp_req=1&output=vast&unviewed_position_start=1&env=vp&impl=s&correlator=" \
-e UID2_JS_SDK_URL="<your-JS-SDK-URL>" \
uid2-esp-standard
```
Expand Down

0 comments on commit 42f4a58

Please sign in to comment.