Adding up budget-not-provided separately #537 #555
Conversation
| row['year_columns'][1][year] = by_hierarchy[hierarchies_with_nonzero_budgets[0]][forwardlooking_budget].get(year) or 0 | ||
| row['year_columns'][1][year] = by_hierarchy[hierarchies_with_nonzero_budgets[0]]['forwardlooking_activities_with_budgets'].get(year) or 0 | ||
| if row['budget_not_provided']: | ||
| by_hierarchy[hierarchies_with_nonzero_budgets[0]]['forwardlooking_activities_with_budget_not_provided'].get(year) or 0 |
There was a problem hiding this comment.
Something doesn’t look quite right here – there’s no equals sign on this line. Presumably this is supposed to say:
row['year_columns'][1][year] += ……or similar?
There was a problem hiding this comment.
Looks like this has been addressed in #556.
|
I don’t think this PR attempts to address #537. I.e. it doesn’t attempt to split the figure for activities that include a budget from the figure for activities that explicitly declare I think it might instead be attempting to address #537 (comment). |
|
Yes, this addresses the comment specifically, but there is no intention to separate the |
I responded to that point in this comment: #537 (comment) But okay, that’s fine. I guess #537 can be closed as a |
Addressing #537
Forwardlooking activities with budget-not-provided will be added up separately instead of replacing the activities that provide budgets.