Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/change-cache #728

Merged
merged 1 commit into from
Feb 21, 2024
Merged

feature/change-cache #728

merged 1 commit into from
Feb 21, 2024

Conversation

Bjwebb
Copy link
Contributor

@Bjwebb Bjwebb commented Oct 9, 2023

Change from database cache to local memory cache, because I think lots of trips to the database is slowing down page load.

This gives 79 SQL queries instead of 498 for the main page.

@Bjwebb Bjwebb mentioned this pull request Oct 9, 2023
@Bjwebb Bjwebb changed the base branch from master to develop October 9, 2023 12:28
@Bjwebb Bjwebb force-pushed the feature/change-cache branch 3 times, most recently from 313b677 to c8d55cf Compare October 13, 2023 13:10
I think lots of trips to the database is slowing down page load.
@Bjwebb Bjwebb force-pushed the feature/change-cache branch from c8d55cf to fd9427a Compare February 21, 2024 12:02
@Bjwebb Bjwebb marked this pull request as ready for review February 21, 2024 13:54
@Bjwebb Bjwebb requested a review from a user February 21, 2024 13:54
@Bjwebb
Copy link
Contributor Author

Bjwebb commented Feb 21, 2024

Deploy of this branch: http://51.141.234.83:5000/en/
It doesn't make a huge difference to loading times, but it does seem to help a bit.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you checked memory use on server ...

@Bjwebb
Copy link
Contributor Author

Bjwebb commented Feb 21, 2024

I've done a crawl of that dev site using linkchecker, and it doesn't seem to make a big difference to memory usage.

@Bjwebb Bjwebb merged commit d5b3446 into develop Feb 21, 2024
3 checks passed
@Bjwebb Bjwebb deleted the feature/change-cache branch February 21, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant