Elasticsearch v6 -> 8, into Docker #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odscjames
force-pushed
the
2024-10-elasticsearch-upgrades
branch
from
44b0a19 to
c60d1ed
Compare
odscjames
changed the title
odscjames
force-pushed
the
2024-10-elasticsearch-upgrades
branch
2 times, most recently
from
7cb0ff0 to
9e03d8e
Compare
odscjames
changed the title
odscjames
changed the title
odscjames
force-pushed
the
2024-10-elasticsearch-upgrades
branch
4 times, most recently
from
7a5e9ea to
784bd9c
Compare
Switch to running in Docker rather than in same container, due to difficulties running latest version directly on Alpine.
odscjames
force-pushed
the
2024-10-elasticsearch-upgrades
branch
from
784bd9c to
1ec8634
Compare
|
Ready for review I can't now remember why I added curl to the Docker build. I can take it out if wanted but it's generally useful. We turn security off for Elasticsearch. If enabled, SSL also has to be enabled with a self signed cert then getting clients to securely connect gets difficult. Security via 2 different firewalls; port 9200 isn't available even on VM (only on the docker internal network). And then Azure firewalls port 9200 anyway. |
|
Prod deploy obvs not tested, double check that's the same as dev deploy pls |
|
I tested restarting VM too |
|
I like this approach. I still need to review the detail. |
Bjwebb
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.