Put the merged dashboard work live #170
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incoming commitment (11) and incoming pledge (13) should also be included.
…urrent for a year
We saw a crash on live and dev:
File "/work/IATI-Publishing-Statistics/IATI-Stats/statsrunner/aggregate.py", line 117, in aggregate
dict_sum_inplace(publisher_total, subtotal)
File "/work/IATI-Publishing-Statistics/IATI-Stats/statsrunner/aggregate.py", line 29, in dict_sum_inplace
dict_sum_inplace(d1[k], v)
File "/work/IATI-Publishing-Statistics/IATI-Stats/statsrunner/aggregate.py", line 37, in dict_sum_inplace
d1[k] += v
TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'
Here is a local test you can run that crashes before this commit and doesn't afterwards:
import statsrunner.aggregate
import types
d1 = { "dogs": 67 }
d2 = { "dogs":None }
statsrunner.aggregate.dict_sum_inplace(d1,d2)
This PR is masking the root error; why is None suddenly coming through?
This however should let processing not crash and carry on
Also, set retry variables specifically rather than rely on defaults. It's clearer that we want retries and we may tweak them later.
…oriati-and-publishingstats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of the IATI Dashboard, IATI Publishing Stats, and Code for IATI analytics. The plan is to merge this in January, when it will also go live on https://dashboard.iatistandard.org/
Equivalent IATI-Dashboard PR: IATI/IATI-Dashboard#627