fix: add missing ENV var from GH deploy workflow #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simon-20
commented
Sep 12, 2024
simon-20
commented
- Add missing env var from Github workflow
- Alter Github variables config template to handle 'prod' domain
* Add missing env var from Github workflow * Alter Github variables config template to handle 'prod' domain
|
Thanks for checking previous PR Tilly, I missed an environment variable from the GH workflow, and the script to help populate that variable didn't handle the prod domain name properly, so this is just small change to fix that. |
tillywoodfield
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.