Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unify handling of empty values in index #25

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

simon-20
Copy link
Contributor

No description provided.

Copy link

@tillywoodfield tillywoodfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable change to me but as I'm not hands on with the Bulk Data Service I would feel better reviewing it if there was a test included, or more explanation of what is being fixed

* Linting that was previously missed
* Two new tests to check the content of the index entries for datasets which fail to download.
* output null instead of empty string when there is no cached download available for the dataset
* rename function that provides list of fields to better describe its purpose
@simon-20 simon-20 force-pushed the fix_handling_null_values_ branch from e3e8a7b to 02d649c Compare October 25, 2024 08:26
@simon-20 simon-20 requested a review from odscjames October 25, 2024 08:33
@simon-20 simon-20 merged commit 4168380 into develop Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants