Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate theme #21

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Translate theme #21

wants to merge 10 commits into from

Conversation

tillywoodfield
Copy link
Contributor

No description provided.

@tillywoodfield
Copy link
Contributor Author

@robredpath I've generated the .po files to be sent for translation: French and Spanish

<li>
<span>
{{ copyright_block() }}
{{ _("© Copyright 2024 United Nations Development Programme, on behalf of the IATI Secretariat") }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tillywoodfield are we sure we want to hard-code the date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I've updated it to be dynamic

"PO-Revision-Date: 2024-11-12 16:24+0200\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language: es\n"
"Language-Team: es <[email protected]>\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this email address?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find a way to remove just this line, as the file is autogenerated, so if we delete it manually it will just overwrite it again next time the command is run

@robredpath
Copy link
Contributor

robredpath commented Nov 15, 2024

This is looking great, thanks @tillywoodfield !

I've emailed SA about how we communicate to them that terms such as CC BY 4.0 aren't to be translated - once we've got that sorted out we can get the translation done.

@tillywoodfield
Copy link
Contributor Author

@Bjwebb are you able to review this from a code perspective please? No rush

babel.cfg Outdated
Comment on lines 5 to 6
ignore_tags = script,style
include_attrs = alt title summary placeholder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these lines for Jinja2, or are they just applicable to Genshi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are unneeded, have removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants