-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate theme #21
base: main
Are you sure you want to change the base?
Translate theme #21
Conversation
f70866a
to
8a3ed45
Compare
@robredpath I've generated the .po files to be sent for translation: French and Spanish |
79c24f9
to
a08f6bb
Compare
iati_sphinx_theme/footer.html
Outdated
<li> | ||
<span> | ||
{{ copyright_block() }} | ||
{{ _("© Copyright 2024 United Nations Development Programme, on behalf of the IATI Secretariat") }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tillywoodfield are we sure we want to hard-code the date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I've updated it to be dynamic
"PO-Revision-Date: 2024-11-12 16:24+0200\n" | ||
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n" | ||
"Language: es\n" | ||
"Language-Team: es <[email protected]>\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this email address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find a way to remove just this line, as the file is autogenerated, so if we delete it manually it will just overwrite it again next time the command is run
This is looking great, thanks @tillywoodfield ! I've emailed SA about how we communicate to them that terms such as CC BY 4.0 aren't to be translated - once we've got that sorted out we can get the translation done. |
@Bjwebb are you able to review this from a code perspective please? No rush |
babel.cfg
Outdated
ignore_tags = script,style | ||
include_attrs = alt title summary placeholder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these lines for Jinja2, or are they just applicable to Genshi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they are unneeded, have removed
471774c
to
09a0e33
Compare
No description provided.