Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI-2773 community source tests enable #544

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

CSI-2773 community source tests enable #544

wants to merge 10 commits into from

Conversation

ArbelNathan
Copy link
Contributor

Signed-off-by: ArbelNathan [email protected]

remove tests to skip
70cc428 
Signed-off-by: ArbelNathan <[email protected]>
oriyarde
oriyarde previously approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@oriyarde oriyarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matancarmeli7
matancarmeli7 previously approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@matancarmeli7 matancarmeli7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

remove tests to skip ds8k
f6e6f84 
Signed-off-by: ArbelNathan <[email protected]>
@ArbelNathan ArbelNathan dismissed stale reviews from matancarmeli7 and oriyarde via f6e6f84 July 19, 2022 08:33
ArbelNathan added 2 commits July 19, 2022 11:42
remove empty line
6b48ae8 
Signed-off-by: ArbelNathan <[email protected]>
revert ds8k and work with virt_snap_func
3e55ef1 
Signed-off-by: ArbelNathan <[email protected]>
@ArbelNathan ArbelNathan marked this pull request as draft July 19, 2022 14:32
ArbelNathan added 6 commits July 19, 2022 17:34
work with virt_snap_func in snapshotclass
7ca3ce5 
Signed-off-by: ArbelNathan <[email protected]>
fix path
d36df71 
Signed-off-by: ArbelNathan <[email protected]>
add pool
fd26bae 
Signed-off-by: ArbelNathan <[email protected]>
add pool in entrypoint-csi-tests.sh
8e2273f 
Signed-off-by: ArbelNathan <[email protected]>
Merge remote-tracking branch 'origin/develop' into fix/CSI-2773_commu…
113769e 
…nity_from_source_enable

# Conflicts:
#	Dockerfile-csi-test
#	scripts/csi_test/entrypoint-csi-tests.sh
revert changes to match #567
785f447 
Signed-off-by: ArbelNathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matancarmeli7 matancarmeli7 matancarmeli7 left review comments

@oriyarde oriyarde oriyarde left review comments

@roysahar roysahar Awaiting requested review from roysahar

@barakda barakda Awaiting requested review from barakda

@ELENAGER ELENAGER Awaiting requested review from ELENAGER

@samishekh samishekh Awaiting requested review from samishekh

@annaparienti annaparienti Awaiting requested review from annaparienti

@benmenachem benmenachem Awaiting requested review from benmenachem

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArbelNathan @matancarmeli7 @oriyarde